search

s6mike / argmap

Tools for visualising argument maps represented in YAML - combining 2 forked repos with additional bugfixes and customisation.
https://argview.org/
Other
4 stars 1 forks source link

Clicking in container restores `overflow: auto` to `element.style` #23

Open s6mike opened 2 years ago

s6mike commented 2 years ago

Thought I had fixed this by commenting out line 110 in mapjs/src/browser/dom-map-widget.js:

element.css('overflow', 'auto').attr('tabindex', 1);

Must be another piece of mapjs code updating it again.

s6mike commented 2 years ago

Introduced in v4.8.17 (12-argmapjs-fixes)

s6mike commented 2 years ago

mapjs/src/browser/dom-map-widget.js:123 looks like it does this, have commented out and will commit around v4.9.1

s6mike commented 2 years ago

When applying an earlier related fix (in v4.8.17) I also commented out the tabindex attribute, which is needed for sequential keyboard navigation, which stopped keyboard shortcuts working when clicking on the container (svg canvas). Fixed in v4.9.4.

s6mike commented 2 years ago

Fixed in argmap 4.9.1 (0c8d299e753c60a3661626f66e861d693ef8b0ff)