search

sPOiDar / fvtt-module-hide-gm-rolls

A FoundryVTT module to hide GM rolls
MIT License
5 stars 11 forks source link

[Feature Request] Add Compatability with Damage Log #34

Closed SirMotte closed 1 year ago

SirMotte commented 1 year ago

I'd like to request compatibility with the Damage Log Module. This may or may not be related to #2 .

Issue: Chat cards added by this module are seemingly not recognized by Hide GM Rolls.

I've already contacted the author of the module as well, please see this post.

If you could either give some insight into how compatibility could be added by the Author of Damage Log, or if you yourself could take a look would be highly appreciated.

Thank you for this wonderful module, makes DMing so much more convenient!

sPOiDar commented 1 year ago

Hey @SirMotte sorry for the delay, haven't had much time for personal projects this year. When you say that chat cards are not recognised, can you elaborate - ie, what did you expect to happen, and what happened instead?

esheyw commented 1 year ago

I just got this warning: Nothing seems obviously broken though.

SirMotte commented 1 year ago

Hey @SirMotte sorry for the delay, haven't had much time for personal projects this year. When you say that chat cards are not recognised, can you elaborate - ie, what did you expect to happen, and what happened instead?

Hey sPOiDar, thanks for replying. I no longer use damage log, since I have switched over to Midi Qol. It's Author has already implemented similar solutions and compatibility with this and the Quick Reveal Module.

Please see this post. https://gitlab.com/tposney/midi-qol/-/issues/1116

Unless you still want to support the module mentioned above, even though I won't use it anymore, I will close this thread for now. Thank you!

Edit: To clarify what the issue was: Damage log has the option to create chat cards that show dealt damage or healing for the GM and/or the players. I wanted to make it so, that I decide when to show the cards in chat by using Hide GM Rolls and the Quick Reveal module. Unfortunately Damage Log chat cards were not properly recognized and thus not hidden from the players. In turn this made use of the quick reveal module impossible as well.