search

sPOiDar / fvtt-module-hide-gm-rolls

A FoundryVTT module to hide GM rolls
MIT License
5 stars 11 forks source link

fix(compatibility): Bump compatibility to v12 #44

Closed WilStead closed 5 months ago

WilStead commented 5 months ago

Fixes #43

Tested all basic module features with Foundry version 12.328 and found them to work without the need for any module changes. Bumped the verified compatibility entry in module.json accordingly.

I removed the maximum compatibility entry. This should let users use this module in future versions, even if it doesn't get updated. We'll just get a warning from Foundry that compatibility hasn't been verified, and we can proceed at our own risk.

Did not test interactions with other modules, since there appears to be at least one outstanding related issue, which this PR isn't intended to address.

sPOiDar commented 5 months ago

This module currently breaks all player cards on the new DND 5e, and I've not had time to fix that (my day job has been sapping all my energy), which is why I haven't published a new version.

I'd also prefer not to set an open max version in case the module breaks people's games in future - IMO it's better to not be installable than to explode someone's game.

Unfortunately I'm about to leave on a trip and will be without access to a computer until early August, so I won't be able to look at this until then.

robert16444 commented 2 months ago

@sPOiDar @WilStead are you still planning to add compatibility for V12?