Hide crit/fumble colours on totals

sPOiDar / fvtt-module-hide-gm-rolls

A FoundryVTT module to hide GM rolls

MIT License

5 stars 11 forks source link

Hide crit/fumble colours on totals #6

Closed manituan closed 4 years ago

manituan commented 4 years ago

I've been waiting for something like this module since I started using Foundry, but to start using it I'd love to see this implemented first:

Remove the colour from the result if the dice roll was 1 (red) or 20 (green). This is revealing to the player the modifier indirectly.
Hide the name of the monster/NPC that it's rolling or mask it with an alias. (forget about this one, I've seen there's a module that does that already)
Attack rolls show the modifiers and damage type.

The first two options could be toggles in the module settings. Thank you!

sPOiDar commented 4 years ago

We should be able to remove the crit/fail colors, though I'd guess you're going to reveal any crits to the players anyway.
There are a number of other modules that let you hide or change the names of the speaker for rolls (or use the token name, which can be randomly generated by token mold). I'm not sure if I want to add that to this module - I prefer to see smaller modules that have limited scope.
What system is that? Because we're already hiding the roll formula when sanitize is enabled:

GM	Player

manituan commented 4 years ago

1.- I'd appreciate it. Ty 2.- Yes, I realised soon after writing this that there are other modules that do this. 100% agree with you. 3.- I'm running Pathfinder 2. Should I contact the developers over there?

Thanks!

sPOiDar commented 4 years ago

They're baking the dice formula into the the flavor text for the roll, so there's no easy way for me to remove it - I'd have to resort to some error-prone text pattern matching to try and strip it out. I don't know if they'd be interested in changing it though, and I'm not sure how deep this is coded into the system - looks like the trigger for the rolls in the char sheet also has this text baked in, so it may be just how the system is written. Probably doesn't hurt to ask if this is easily removed though.

sPOiDar commented 4 years ago

I've pushed a change to hide the crit/fumble colours, that will be released soon, so I'm going to close this one out with that. If you hear anything about PF2E one way or the other, please feel free to open a new issue and we'll see if we can do anything sensible here.