bug: closed modal still focusable

Atmos4 commented 9 months ago

What version of daisyUI are you using?

v4.7.2

Which browsers are you seeing the problem on?

All browsers

Reproduction URL

https://play.tailwindcss.com/iFzG1xCAcv

Describe your issue

When a modal is closed, it can still receive focus (i.e. from keyboard).

This is a known conundrum about animating modals:

if you apply visibility: hidden to closed modal styles, closing transition will not display properly (can be fixed with transition-behavior: allow-discrete but browser support is very bad).
if you don't apply visibility: hidden, the modal will be focusable even when closed.

A fix for this would be:

warn about this issue in the documentation
add an example in the docs that fixes this issue with Javascript.

Note: maybe there is another solution to this problem using some other technique that I don't know about.

Let me know if you want me to create a PR for this!

github-actions[bot] commented 9 months ago

Thank you @Atmos4 for reporting issues. It helps daisyUI a lot 💚
I'll be working on issues one by one. I will help with this one as soon as a I find a solution.
In the meantime providing more details and reproduction links would be helpful.

saadeghi commented 7 months ago

duplicate of #2223

saadeghi / daisyui