saadeghi / daisyui

๐ŸŒผ ๐ŸŒผ ๐ŸŒผ ๐ŸŒผ ๐ŸŒผ โ€ƒThe most popular, free and open-source Tailwind CSS component library
https://daisyui.com
MIT License
34.24k stars 1.31k forks source link

Docs: Update theme generator #2963

Closed TreyRuffy closed 7 months ago

TreyRuffy commented 7 months ago

Added a button to show all colors in the theme generator.

With the switch off: image

With the switch on: image

TreyRuffy commented 7 months ago

I realized I have to make a couple more changes before it can be merged. Expect them later today / tomorrow.

TreyRuffy commented 7 months ago

I forgot to leave a comment but this should now be ready for reviewing. Lmk if there's anything I should change!

saadeghi commented 7 months ago

Hey,
Thanks for the PR, (and sorry for the spaghetti code of this page ๐Ÿ˜…)
There's an issue with the value of all optional colors. It shows a color on the demo but another color on the code:

Screenshot 2024-04-13 at 3 58 54โ€ฏPM

You can see this happening by pressing the random button a few times. For example in above screenshot, you can see *-content color of buttons don't match the ones in the code. Or the base-content color which should be dark in this screenshot but in the preview is light.

TreyRuffy commented 7 months ago

I was able to fix that issue in the latest commit. Additionally, I added a button to automatically generate the optional colors.

Show all enabled: image

Show all disabled: image

sovetski commented 7 months ago

Looks very good! Maybe it is not the correct place here, but what do you think guys about adding also border radius config to the theme generator config?

saadeghi commented 7 months ago

Thanks