search

saagie / updatarium

Updatarium : Update everything
Apache License 2.0
14 stars 6 forks source link

:sparkles: Add persist engine admin cli #102

Closed Y-Henry closed 4 years ago

Y-Henry commented 4 years ago

Add the persist engine admin cli. Implements the find all changesets execution. Add 2 methods to persist engine.

Cli Commands

./updatarium-admin-cli --help

Usage: standalone [OPTIONS] COMMAND [ARGS]...

Options:
  -h, --help  Show this message and exit

Commands:
  list  List the changeSet executions

./updatarium-admin-cli list --help

Usage: updatarium-admin-cli list [OPTIONS]

  List the changeSet executions

Options:
  --limit INT                      limit the changeSet display count (default
                                   10, min 0, max 1000)
  --skip INT                       skip some changeSets (default 0, min 0)
  -c, --change-set-id TEXT         filter with one specific change set
  -s, --with-status [NOT_EXECUTED|EXECUTE|OK|FAIL]
                                   filter executions with specific status
  -e, --with-error                 filter failed execution
PierreLeresteux commented 4 years ago

You should edit the README.md and the CONTRIBUTING.md (https://github.com/saagie/updatarium/blob/master/CONTRIBUTING.md#persist-engine-creation)

You should try to launch the build gradle, because, you omit to add the license header (a gradle task for the auto format is also include -> see the tasks list)

Y-Henry commented 4 years ago

Licence task run, README.md and CONTRIBUTING.md updated

PierreLeresteux commented 4 years ago

I think findExecutionHistoric should not be in the PersistEngine ... It's a dedicated function for the standalone ... No need to implement it for each PersistEngine

Y-Henry commented 4 years ago

It was just a way to validate the arguments directly into the repository and confirm that every implementations have the same pagination constraint. I was just block by the same signature and have to rename the to-implement part.