sabbelasichon / typo3-rector

Rector for TYPO3
MIT License
226 stars 63 forks source link

Allow nikic/php-parser v5 (TYPO3 13 compatibility) #4247

Open kevin-appelt opened 5 months ago

kevin-appelt commented 5 months ago

The issue

TYPO3 Rector does block the update to the just released TYPO3 v13.1 due to dependency conflicts.

Composer error message

- Root composer.json requires ssch/typo3-rector 2.5.0 -> satisfiable by ssch/typo3-rector[v2.5.0].
- typo3/cms-install 13.2.x-dev is an alias of typo3/cms-install dev-main and thus requires it to be installed too.
- typo3/cms-install[dev-main, v13.1.0] require nikic/php-parser ^5.0.1 -> satisfiable by nikic/php-parser[v5.0.1, v5.0.2, 5.0.x-dev].
- Conclusion: don't install nikic/php-parser v5.0.2 (conflict analysis result)
- Root composer.json requires typo3/cms-install ^13.1 -> satisfiable by typo3/cms-install[v13.1.0, 13.2.x-dev (alias of dev-main)].

The dependency conflict

typo3/cms-install requires "nikic/php-parser": "^5.0.1" ssch/typo3-rector requires "nikic/php-parser": "^4.18.0"

The solution

Allow installation of nikic/php-parser v5 (maybe in addition to v4 if needed/possible).

This might help somehow

Quickfix

Just in case someone stumbles across this issue as long as it is not resolved. Removing TYPO3 Rector (for now) does allow installation of TYPO3 v13.1

sabbelasichon commented 5 months ago

@kevin-appelt Thanks for reporting it. We should rather make TYPO3 compatible for v4 and v5 of nikic/php-parser. The task should be much simpler.

simonschaufi commented 4 months ago

This is mostly blocked by Rector itself as Rector itself is not compatible with nikic/php-parser v5, see https://github.com/rectorphp/rector/issues/8567