search

sabinesin / nuclear-vis

Nuclear Detonations InfoVis
1 stars 0 forks source link

Detailed Timeline Updating #16

Closed Tanner closed 11 years ago

Tanner commented 11 years ago

Continuing a conversation from #14.

Tanner commented 11 years ago

In response to @sabinesin's last comment: I couldn't replicate your images. It seems to work as expected to me from the f18d3a2 (current HEAD on master).

I haven't looked at the code for how it gets updated, but perhaps if every time the brush start/end is changed, we can get the start/end dates for the brush and use that to generate the bounds for the detailed timeline?

sabinesin commented 11 years ago

The pictures are after I commented out this line which use start/end times rounded (taking the ceiling) x2.domain(d3.event.target.empty() ? x2.domain() : [adjustedMin, adjustedMax]); and instead use this line which I think is what you mean with your previous suggestion, but is what my previous screenshots are generated from x2.domain(d3.event.target.empty() ? x2.domain() : d3.event.target.extent());

Tanner commented 11 years ago

I'm not sure if we decided anything for this or what. I'm not even sure what this is about anymore.

Tanner commented 11 years ago

Oh I think this was about getting the detail timeline to update when the brush moved.

Tanner commented 11 years ago

I moved the code that updated the detailed timeline into brush move and it really slows everything down so that the main map doesn't show the animations anymore.

recording

I don't think we'll animate it.