sablier-labs / docs

Documentation and guides for Sablier
https://docs.sablier.com
GNU General Public License v3.0
14 stars 7 forks source link

Enable Vercel Analytics #131

Open PaulRBerg opened 5 months ago

PaulRBerg commented 5 months ago
SCR-20240201-smem
PaulRBerg commented 5 months ago

We would have to implement a cookie banner to enable these analytics, wouldn't we, @razgraf, @gavriliumircea?

gavriliumircea commented 5 months ago

Yus but we should use the cookie banner that we already have

PaulRBerg commented 5 months ago

Got it. Would it be difficult to port that over to this repository?

Related: https://github.com/sablier-labs/v2-interfaces/discussions/454

gavriliumircea commented 5 months ago

First of all we don't actually have a roadmap for the sdk. Further more we will be able to put there the component itself but the entire cookies system is a different discussion, we have a store related to those, config function, project keys so the complexity is increasing exponentially.

PaulRBerg commented 5 months ago

First of all we don't actually have a roadmap for the sdk

I know. When I add related links, I just put it there for historical association reasons - not to push it as a high-priority item today.

Further more we will be able to put there the component itself but the entire cookies system is a different discussion

Surely we can have a minimal component just for the Vercel analytics and Crisp? We don't need Sentry and Mixpanel and the other stuff in the docs.


Maybe Docusaurus has a pre-fab solution for cookies? More research needed.

gavriliumircea commented 5 months ago

We should discuss this in the call we have next week.

razgraf commented 5 months ago

Worth noting that the SDK isn't very related to this discussion. The SDK would include Sablier branded elements (UI or flows) for integrators to use.

The "legal" components like any other very opinionated functionalities (like the cookie banner) would most likely not live in an SDK. Maybe in a shared internal components package (but we have that for now in the interfaces monorepo).


Looks like Vercel Analytics should be valid for an integration with Docusaurus. There's still the question of what the best approach is e.g., injecting the Analytics RC and handling beforeSend like in the app vs. using the plugin vs. other

Related links:

PaulRBerg commented 5 months ago

Worth noting that the SDK isn't very related to this discussion. ... The "legal" components like any other very opinionated functionalities (like the cookie banner) would most likely not live in an SDK

You're right.

Looks like Vercel Analytics should be valid for an integration with Docusaurus

Nice