search

saebekassebil / teoria

Javascript taught Music Theory
http://saebekassebil.github.io/teoria
MIT License
1.31k stars 114 forks source link

removing teoria.js from .npmignore #122

Open JackCA opened 6 years ago

JackCA commented 6 years ago

I'd like to use teoria with ember-cli and for various reasons I'd like to avoid using browserify -- a plain build file would be helpful when using an npm package.

Would you be open to removing the teoria.js build file from .npmignore?

saebekassebil commented 6 years ago

Hey Jack!

I’m not sure I follow - could you explain how one “uses teoria with ember-cli”?

Den 12. okt. 2017 kl. 03.14 skrev Jack Anderson notifications@github.com:

I'd like to use teoria with ember-cli and for various reasons I'd like to avoid using browserify -- a plain build file would be helpful when using an npm package.

Would you be open to removing the teoria.js build file from .npmignore?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

JackCA commented 6 years ago

Hey @saebekassebil -- sorry, I wasn't very clear 😬

The current .npmignore lists the teoria.js build file, which means that any project that has teoria as a dependency, won't have access to that file.

In my specific case, I'd like to use that file via npm, rather than browserify the index.js file.

The implementation of this is here: https://github.com/JackCA/teoria/commit/fb4aa29de90cbe5b0b69ce78e7a20b9c702e97eb