safe-global / safe-apps-list

MIT License
20 stars 31 forks source link

Update Balancer Safe App #383

Closed agualis closed 4 months ago

agualis commented 4 months ago

Entry type

Related question: Note that the new https://balancer.fi leads to our landing page where clicking Launch app goes to the real app at https://balancer.fi/pools. So I believe it makes more sense to serve the manifest.json from /pools like we do here. Do you have a recommendation?

App info

URL: https://balancer.fi/pools

Name: Balancer

Description: Balancer is a battle-tested toolkit for true AMM experimentation and innovation.

Icon (PNG, 180x180): balancer

Homepage: https://balancer.fi Twitter: https://x.com/Balancer GitHub: https://github.com/balancer Discord: https://discord.balancer.fi/

App supports batching multiple transactions via Safe: not yet (it is in the roadmap)

Supported networks

Ethereum (Mainnet) Arbitrum Avalanche Base Fantom Fraxtal Gnosis Mode Optimism Polygon Polygon Zkevm

Revision checks

Audit document

https://github.com/balancer/balancer-v2-monorepo/tree/master/audits

Code for review

https://github.com/balancer/frontend-v3

Team information

Company: Balancer

Official website: balancer.fi

Point of contact: https://discord.balancer.fi/

kirkkonen commented 4 months ago

Reviewed and approved by the Product team.

katspaugh commented 4 months ago

@agualis yes, it makes sense to open directly /pools. Let me know when the manifest is there and I'll update the URL. Will use https://balancer.fi for now.

katspaugh commented 4 months ago

Updated the app here: https://app.safe.global/share/safe-app?appUrl=https%3A%2F%2Fbalancer.fi&chain=eth

katspaugh commented 4 months ago

Also please note that the new icon isn't very visible in dark mode. If you have the logo on e.g. white background, that'd be better.

Screenshot 2024-07-31 at 10 06 15
agualis commented 4 months ago

Hey @katspaugh I confirm that we already have this manifest.json:

https://balancer.fi/pools/manifest.json

so the Safe app can point to https://balancer.fi/pools

Here is the updated logo:

balancer

Thank you!

agualis commented 3 months ago

Hey @katspaugh,

would it be possible to have different urls for the app and the manifest?

For instance: App: https://balancer.fi/pools Manifest: https://balancer.fi/balancer/manifest.json

Context: We are working in a new app that will be built within the same nextjs repository but next does not allow to dynamically generate 2 different manifest.json like this:

https://balancer.fi/pools/manifest.json https://beets.fi/pools/manifest.json

The only workaround would be using this option to have two different manifests like this:

https://balancer.fi/balancer/manifest.json https://beets.fi/beets/manifest.json

Thanks!

katspaugh commented 3 months ago

AFAIU Safe Apps manifest.json has nothing to do with the one Next.js helps generate. It's just a static file you can write by hand and serve from any URL you want.

agualis commented 3 months ago

You can choose to serve the same manifest.json that next generates or you can use an static version.

If there's no other chance we will do the second but in case you supported that option that would make our build process more flexible and simple.

groninge01 commented 3 months ago

Hey @katspaugh,

A possible fix for this issue is to retrieve the path to the manifest dynamically from the (custom) app's page. It is then the (custom) app's responsibility to make sure this path is correct and available.

I have created a suggestion here. Let me know what you think about it.

katspaugh commented 3 months ago

We won't be changing the way the manifest is loaded at this time, sorry.

agualis commented 3 months ago

Ok thanks. We will find a workaround in our side.