safe-global / safe-ios

Safe Multisig iOS app.
GNU General Public License v3.0
115 stars 37 forks source link

GH-3262 rewrote approval function #3392

Closed DmitryBespalov closed 10 months ago

DmitryBespalov commented 10 months ago

Handles #3262

Changes proposed in this pull request:

codecov[bot] commented 10 months ago

Codecov Report

Attention: 807 lines in your changes are missing coverage. Please review.

Comparison is base (2b3ddf0) 8.14% compared to head (c687fab) 8.27%. Report is 33 commits behind head on main.

Files Patch % Lines
...Connect to Web/Logic/WebConnectionController.swift 0.00% 234 Missing :warning:
...sViewController/TransactionDetailCellBuilder.swift 0.00% 102 Missing :warning:
Multisig/Logic/Models/EIP712Transformer.swift 0.00% 70 Missing :warning:
...cureConfig/Sources/SecureConfig/SecureConfig.swift 0.00% 59 Missing :warning:
... Web/Logic/WebConnectionToSessionTransformer.swift 0.00% 49 Missing :warning:
...ntroller/ReviewSafeTransactionViewController.swift 0.00% 49 Missing :warning:
...Connect to Web/Logic/WebConnectionRepository.swift 0.00% 44 Missing :warning:
...isig/UI/WalletConnectV2/WalletConnectManager.swift 48.05% 40 Missing :warning:
...let/UI/SendTransactionToWalletViewController.swift 0.00% 19 Missing :warning:
...isig/Cross-layer/Configuration/Configuration.swift 0.00% 17 Missing :warning:
... and 23 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3392 +/- ## ======================================== + Coverage 8.14% 8.27% +0.13% ======================================== Files 786 789 +3 Lines 43371 44062 +691 ======================================== + Hits 3532 3647 +115 - Misses 39839 40415 +576 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.