safe-global / safe-smart-account

Safe allows secure management of blockchain assets.
https://safe.global
GNU Lesser General Public License v3.0
1.84k stars 907 forks source link

Feature: bytecode size reduction by removing public `getChainId` function, making encodeTransactionData private #603

Closed mmv08 closed 1 year ago

mmv08 commented 1 year ago

This PR is a pre-requisite for future 1.5.0 features like the overloaded checkNSignatures and the module guard.

Code size after all the changes:

Safe 22913 bytes (limit is 24576)
SafeL2 23755 bytes (limit is 24576)
github-actions[bot] commented 1 year ago

Pull Request Test Coverage Report for Build 5473862599


Totals Coverage Status
Change from base Build 5455854105: -0.01%
Covered Lines: 313
Relevant Lines: 328

💛 - Coveralls