search

safe-global / safe-smart-account

Safe allows secure management of blockchain assets.
https://safe.global
GNU Lesser General Public License v3.0
1.84k stars 907 forks source link

Unused storage variable. #616

Closed allwin199 closed 1 year ago

allwin199 commented 1 year ago

Description

safe.sol line 68 

mapping(bytes32 => uint256) public signedMessages;

Unused storage variable. This can be commented or removed.

allwin199 commented 1 year ago

If it has to be commented or removed, I can raise a PR.

mmv08 commented 1 year ago

It was used in the old safe contract version, and for smooth upgrades between versions, we do not change the storage layout.

Saw-mon-and-Natalie commented 11 months ago

@mmv08 can still add a comment and rename the variable to deprecatedSignedMessages.

mmv08 commented 11 months ago

@mmv08 can still add a comment and rename the variable to deprecatedSignedMessages.

That's true. Feel free to create a PR. Just a note: it's not deprecated but the functionality was moved to the SignMessageLib library that requires a DELEGATECALL