search

safe-global / safe-smart-account

Safe allows secure management of blockchain assets.
https://safe.global
GNU Lesser General Public License v3.0
1.84k stars 907 forks source link

Formal verification: Add rules for modules #635

Closed mmv08 closed 1 year ago

mmv08 commented 1 year ago

This PR is based on https://github.com/safe-global/safe-contracts/pull/632 and adds similarly fashioned rules but for the modules linked list

github-actions[bot] commented 1 year ago

Pull Request Test Coverage Report for Build 5854116454

Totals Coverage Status
Change from base Build 5832522034: 0.0%
Covered Lines: 320
Relevant Lines: 340
💛 - Coveralls
jhoenicke commented 1 year ago

Looks good. One thing I noticed is that there is no rule that checks wether isModuleEnabled(SENTINAL) returns false.

mmv08 commented 1 year ago

@jhoenicke invariant is added now. Thank you