Fix: Solidity linter errors

safe-global / safe-smart-account

Safe allows secure management of blockchain assets.

https://safe.global

GNU Lesser General Public License v3.0

1.84k stars 907 forks source link

Fix: Solidity linter errors #650

Closed mmv08 closed 1 year ago

mmv08 commented 1 year ago

This PR:

Fixes solidity lint errors from new rules by the updated linter in #641
Mostly, the fixed errors are either no-inline-assembly or no-global-import. I also turned off the rule that forced only one contract per file, including interfaces, which doesn't make much sense to me

github-actions[bot] commented 1 year ago

Pull Request Test Coverage Report for Build 6028829923

10 of 15 (66.67%) changed or added relevant lines in 5 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 92.78%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
contracts/examples/guards/DelegateCallTransactionGuard.sol	2	3	66.67%
contracts/test/Test4337ModuleAndHandler.sol	0	4	0.0%
<!--	Total:	10	15	66.67%	-->

Totals
Change from base Build 6024269180:	0.0%
Covered Lines:	320
Relevant Lines:	340

💛 - Coveralls

akshay-ap commented 1 year ago

Could we update the rule here to avoid warnings? https://github.com/safe-global/safe-contracts/blob/cf843da5a599c7abf59624a5ac421d78730732e9/.eslintrc.js#L16

mmv08 commented 1 year ago

Could we update the rule here to avoid warnings?

https://github.com/safe-global/safe-contracts/blob/cf843da5a599c7abf59624a5ac421d78730732e9/.eslintrc.js#L16

Ideally, we remove any from the code and add better types. I'd keep it as is and tackle it in a separate PR that fixes TS linter errors.