safe-global / safe-smart-account

Safe allows secure management of blockchain assets.
https://safe.global
GNU Lesser General Public License v3.0
1.84k stars 907 forks source link

Don't use the word "Confirm" #659

Closed SKYBITDev3 closed 1 year ago

SKYBITDev3 commented 1 year ago

A "confirmation" in relation to blockchain refers commonly to completion of transaction processing by a miner or validator on the blockchain network.

So using the word "confirm" and related words in Safe can cause confusion, especially for newcomers who may already find it difficult enough to set up and use Safe.

Better alternative words for Safe transaction proposal approval may be: Accept Agree

I don't suggest "approve" because approve is a standard function in token contracts for adjusting spending allowance.

mmv08 commented 1 year ago

This is the repo for smart contracts. Please create it in the corresponding repo.

SKYBITDev3 commented 1 year ago

OK I've done it in the wallet repository: https://github.com/safe-global/safe-wallet-web/issues/2517

Though UI updates would need to be made in the mobile wallet repositories too.