codecov[bot]
commented
1 year ago Codecov Report
Base: 52.45% // Head: 52.47% // Increases project coverage by +0.01% :tada:
Coverage data is based on head (
a410925) compared to base (d2f9367). Patch coverage: 91.66% of modified lines in pull request are covered.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #416 +/- ## ========================================== + Coverage 52.45% 52.47% +0.01% ========================================== Files 52 53 +1 Lines 5793 5795 +2 ========================================== + Hits 3039 3041 +2 Misses 2754 2754 ``` | [Impacted Files](https://codecov.io/gh/sagebind/isahc/pull/416?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Stephen+M.+Coakley) | Coverage Δ | | |---|---|---| | [src/agent/selector.rs](https://codecov.io/gh/sagebind/isahc/pull/416/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Stephen+M.+Coakley#diff-c3JjL2FnZW50L3NlbGVjdG9yLnJz) | `75.94% <ø> (-0.19%)` | :arrow_down: | | [src/agent/hasher.rs](https://codecov.io/gh/sagebind/isahc/pull/416/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Stephen+M.+Coakley#diff-c3JjL2FnZW50L2hhc2hlci5ycw==) | `77.77% <77.77%> (ø)` | | | [src/agent/mod.rs](https://codecov.io/gh/sagebind/isahc/pull/416/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Stephen+M.+Coakley#diff-c3JjL2FnZW50L21vZC5ycw==) | `77.77% <100.00%> (-0.12%)` | :arrow_down: | | [src/client.rs](https://codecov.io/gh/sagebind/isahc/pull/416/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Stephen+M.+Coakley#diff-c3JjL2NsaWVudC5ycw==) | `82.28% <100.00%> (-0.07%)` | :arrow_down: | | [src/handler.rs](https://codecov.io/gh/sagebind/isahc/pull/416/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Stephen+M.+Coakley#diff-c3JjL2hhbmRsZXIucnM=) | `80.82% <100.00%> (+0.35%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Stephen+M.+Coakley). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Stephen+M.+Coakley):umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Remove the following dependencies:
rustls-ffi: We don't actually need this directly, as curl pulls it in transitively as needed. Listing this as a direct dependency was unnecessary.slab: Performance testing yields no significant memory or performance improvements over just using aHashMapfor our purposes, so replace the one occurrence of slab in the agent with aHashMapusing a unique ID derived from the curl easy handle to keep track of requests.Also add comments to
Cargo.tomlnext to each runtime dependency which explains how the dependency is used and why it is there.