sagemath / binary-pkg

Tools for creating binary tarballs
Other
13 stars 11 forks source link

Error creating runtime binarys with bdist-sage-linux #11

Open millermj1 opened 7 years ago

millermj1 commented 7 years ago

If I clone https://github.com/sagemath/binary-pkg.git, edit sage.yaml to change the branch from develop to master, and run:

then I get the errors:

All the files in the directory .../binary-pkg/source/SageMath/.../local/share/doc/sage/html/en/reference/calculus/sage/calculus end in html .

Without the "export package" line, the compile succeeds, but I want to shrink the size as much as possible.

Thanks!

vbraun commented 7 years ago

Yes the runtime binary part isn't used regularly. The exclude: lines in sage.yaml need to be merged, anything at " Full binary tarball" needs to be added to "Runtime binaries only" if its not there already. PR would be welcome..

millermj1 commented 7 years ago

Thanks - I will try that.

In looking at sage.yaml, I notice that the rewrite_path begins with "&" in the "Full binary tarball", but begins with "*" in the "Runtime binaries only". Should both begin with "&" ?

What PR would you like?

On Thu, Jun 22, 2017 at 2:35 PM, Volker Braun notifications@github.com wrote:

Yes the runtime binary part isn't used regularly. The exclude: lines in sage.yaml need to be merged, anything at " Full binary tarball" needs to be added to "Runtime binaries only" if its not there already. PR would be welcome..

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sagemath/binary-pkg/issues/11#issuecomment-310465721, or mute the thread https://github.com/notifications/unsubscribe-auth/AcQ-_EJuLnpyFGmMIgbDOnIKNNaB1ZwXks5sGrQKgaJpZM4OCrJG .

vbraun commented 7 years ago

Thats just YAML syntax, the rewrite_path is assigned (&) to the REWRITE_PATH_DEFAULT variable and referenced (*) later.

Only the files: section of "Runtime binaries only" needs updating....

millermj1 commented 7 years ago

I'm new to YAML syntax, so please forgive my confusion.

If you're doing "Runtime binaries only", it seems like the assignment "rewrite_path: &REWRITE_PATH_DEFAULT" in the section "Full binary tarball" would not run, so that the later reference "rewrite_path: *REWRITE_PATH_DEFAULT" in the section "Runtime binaries only" would be undefined.

What I'm wondering is if I need to change to "rewrite_path: &REWRITE_PATH_DEFAULT" in the section "Runtime binaries only".

Thanks

On Thu, Jun 22, 2017 at 3:15 PM, Volker Braun notifications@github.com wrote:

Thats just YAML syntax, the rewrite_path is assigned (&) to the REWRITE_PATH_DEFAULT variable and referenced (*) later.

Only the files: section of "Runtime binaries only" needs updating....

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sagemath/binary-pkg/issues/11#issuecomment-310475739, or mute the thread https://github.com/notifications/unsubscribe-auth/AcQ-_NGMTc9oTY_e-oYhB11upddGmiLcks5sGr1ngaJpZM4OCrJG .

vbraun commented 7 years ago

No, the rewrite_path is correct as it stands. Only the files: section of "Runtime binaries only" needs updating....