search

sagemath / sage-release-management

Utility scripts for release managements
1 stars 1 forks source link

Merge PR through github API #2

Open tobiasdiez opened 1 year ago

tobiasdiez commented 1 year ago

Currently, https://github.com/sagemath/sage-release-management/blob/a246c8667ee8ee2f5723476d18d0ff82b5fd153a/git_sage/repo/release_merge.py#L78-L90 only creates a commit but not (directly) merges the PR. Here is the API for it: https://docs.github.com/en/rest/pulls/pulls?apiVersion=2022-11-28#merge-a-pull-request

vbraun commented 1 year ago

Yes because I currently run the buildbot with the merge commit and only push it to develop if the checks pass. A bit like a merge queue.

tobiasdiez commented 1 year ago

At https://github.com/sagemath/sage/pull/35062, I'm proposing to activate github's new merge queue feature. What would be needed to make this equivalent to your current setup using the buildbot?

vbraun commented 1 year ago

I haven't used it but the real task is to set up CI that adequately covers the supported platforms, not turning on the merge queue feature.

mkoeppe commented 1 year ago

What platforms do you test, Volker?

vbraun commented 1 year ago

I'm apparently building some platform-independent parts that aren't covered by the current ci, e.g. pdf docs

The builders are here: http://build.sagemath.org/#/builders

mkoeppe commented 1 year ago

On that page, where does one see what system packages are installed, and how you configure the build?

mkoeppe commented 1 year ago

Yes, we should add a PDF doc builder to the CI that runs for every ticket.

vbraun commented 1 year ago

The buildbot workers are all minimal installations, the worker configuration is in https://github.com/sagemath/buildbot-sage/blob/master/sage_bot/workers.py

mkoeppe commented 1 year ago

Thanks, I'll take a look.

By the way, a PDF builder is added in https://github.com/sagemath/sage/pull/35169