search

sagemath / sage

Main repository of SageMath
https://www.sagemath.org
Other
1.47k stars 487 forks source link

Adding anticommutator feature #13606

Closed 4dcb6662-e430-4fce-a9cb-91b926d258e6 closed 11 years ago

4dcb6662-e430-4fce-a9cb-91b926d258e6 commented 12 years ago

When working with matrices, the commutator is a useful feature. However, the anticommutator is handy when one is working with representations of, say, Clifford algebras.

Apply: attachment: trac_13606-anticommutator-ts.patch

Component: linear algebra

Author: Oscar Castillo-Felisola, Travis Scrimshaw

Reviewer: Kannappan Sampath

Merged: sage-5.10.beta0

Issue created by migration from https://trac.sagemath.org/ticket/13606

KPanComputes commented 11 years ago
comment:2

I'd like to review this ticket. Here are my comments:

  1. Please fix the docstring: we need "anticommutator" and NOT "commutator". I'd be glad if you rewrote the docstring along the lines of: 
"""
Return the anticommutator of ``self`` and ``other``. 

The anticommutator of two square matrices `A` and `B` of same 
dimension is defined to be `AB + BA`. 

EXAMPLES::

"""
  1. Perhaps, we could add atleast one more example, like the trace of anticommutator. May be, also, how the product AB is related to commutator and anticommutator of A and B. But, this is just my feeling.

Other than these, the patch looks great! :)

KPanComputes commented 11 years ago

Reviewer: Kannappan Sampath

KPanComputes commented 11 years ago

Author: Oscar Castillo-Felisola

tscrim commented 11 years ago

Attachment: trac_13606-anticommutator-ts.patch.gz

tscrim commented 11 years ago

Description changed:

--- 
+++ 
@@ -1 +1,5 @@
 When working with matrices, the commutator is a useful feature. However, the anticommutator is handy when one is working with representations of, say, Clifford algebras.
+
+---
+
+Apply: [attachment: trac_13606-anticommutator-ts.patch]
tscrim commented 11 years ago

Changed author from Oscar Castillo-Felisola to Oscar Castillo-Felisola, Travis Scrimshaw

tscrim commented 11 years ago
comment:4

I've uploaded a patch which fixes up the documentation.

For patchbot:

Apply: trac_13606-anticommutator-ts.patch

tscrim commented 11 years ago
comment:6

Thanks for the review.

jdemeyer commented 11 years ago

Description changed:

--- 
+++ 
@@ -2,4 +2,4 @@

 ---

-Apply: [attachment: trac_13606-anticommutator-ts.patch]
+Apply: [attachment: trac_13606-anticommutator-ts.patch](https://github.com/sagemath/sage-prod/files/10656471/trac_13606-anticommutator-ts.patch.gz)
jdemeyer commented 11 years ago

Merged: sage-5.10.beta0