Open videlec opened 6 years ago
I'll change it soon with a forced push.
Good. If you update the ticket description as well it will even be better.
Description changed:
---
+++
@@ -6,7 +6,7 @@
to
-Real Floating-point Field with XX bits of precision +Real Floating-Point Field with XX bits of precision
The reason for this change is that "Real Field" is not precise enough. Beyond floating-point, "Real Field" could equivalently be used for fixed-point, intervals and balls. The standard terms in the literature are "floating-point arithmetic", "fixed-point arithmetic", "ball arithmetic" and "interval arithmetic", see eg
@@ -21,7 +21,7 @@
for file in $(grep -l "Real Field with" $(find . -name "pyx" -o -name "py" -o -name "pxd" -o -name "rst" -type f))
Tests work fine except for doctests that involves an output with a linebreak such as
@@ -36,11 +36,11 @@
for file in $(find . -name "pyx" -o -name "py" -o -name "pxd" -o -name "rst" -type f) do
-As part of this ticket, the printf percentage syntax has been changed to the Python 3 standard format
syntax (see comment:22) in all real field representations.
+As part of this ticket, the printf percentage syntax has been changed to the newer Python 3 standard format
syntax (see comment:22) in all real field representations.
There we go.
Changed reviewer from Vincent Klein to Vincent Klein, Vincent Delecroix
Thanks. If neither patchbot nor developers complain I will set a positive review.
Do we have a followup for Complex Field
? Because it has the same problem.
rebase please
It was asked on the sage-devel discussion whether people have an opinion.
Replying to [ticket:24523 ticket description]:
We change the string representation of
RealField(XXX)
fromReal Field with XX bits of precision
to
Real Floating-Point Field with XX bits of precision
+1 from me
I wonder a bit about the changes in src/sage/tests/books/
. Is that how it should be?
Replying to @mjungmath:
I wonder a bit about the changes in
src/sage/tests/books/
. Is that how it should be?
Yes
rebase
Setting new milestone based on a cursory review of ticket status, priority, and last modification date.
Setting a new milestone for this ticket based on a cursory review.
We change the string representation of
RealField(XXX)
fromto
The reason for this change is that "Real Field" is not precise enough. Beyond floating-point, "Real Field" could equivalently be used for fixed-point, intervals and balls. The standard terms in the literature are "floating-point arithmetic", "fixed-point arithmetic", "ball arithmetic" and "interval arithmetic", see eg
This ticket is part of a the refactorization #24457 that intends to clean computations involving the different kinds of real numbers.
The git branch was obtained by running the following command in
$SAGE_ROOT/src
Tests work fine except for doctests that involves an output with a linebreak such as
(from
src/sage/tests/french_book/polynomes.py
line 218). These can also be handled using multiline sed replacementAs part of this ticket, the printf percentage syntax has been changed to the newer Python 3 standard
format
syntax (see comment:22) in all real field representations.Related discussion on sage-devel.
Component: basic arithmetic
Author: Vincent Delecroix, Ralf Stephan, Michael Jung
Branch/Commit: u/gh-mjungmath/24523 @
7f7d902
Reviewer: Vincent Klein, Vincent Delecroix
Issue created by migration from https://trac.sagemath.org/ticket/24523