search

sagemath / sage

Main repository of SageMath
https://www.sagemath.org
Other
1.44k stars 480 forks source link

Improvements for morphisms of ModulesWithBasis #8678

Closed nthiery closed 9 years ago

nthiery commented 14 years ago

This ticket implements:

Declares CombinatorialFreeModule indexed by a finite set as being finite dimensional.

Depends on #10668 Depends on #17160

CC: @sagetrac-sage-combinat

Component: categories

Keywords: homsets, module morphisms, days64

Author: Nicolas M. Thiéry

Branch/Commit: 71b36da

Reviewer: Franco Saliola

Issue created by migration from https://trac.sagemath.org/ticket/8678

nthiery commented 14 years ago

Description changed:

--- 
+++ 
@@ -1,5 +1,8 @@
-The upcoming patch in the Sage-Combinat queue will implement:
+The upcoming patch in the Sage-Combinat queue implements:
 - inverses for morphisms of finite dimensional vector spaces
 - tensor products of morphisms

-At this occasion, it will start a bit of cleanup in the category framework for homsets
+and improves:
+- triangular morphisms over base rings
+
+At this occasion, it starts a bit of cleanup in the category framework for homsets, fixing some known issues (failing _test_category).
nthiery commented 14 years ago

Changed keywords from homsest to homsets, module morphisms

saraedum commented 11 years ago
comment:3

This is is a very old ticket. Anyway, can I find the patch that fixes _test_category somewhere? This also fails for #15154. Or should I just disable these tests?

saraedum commented 11 years ago
comment:4

Replying to @saraedum:

This is is a very old ticket. Anyway, can I find the patch that fixes _test_category somewhere? This also fails for #15154. Or should I just disable these tests?

Since there is no reply here, I created a partial fix at #15232.

nthiery commented 10 years ago

Branch: u/nthiery/categories/module-morphisms-8678

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 10 years ago

Commit: 47e0eb9

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 10 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

47e0eb98678: Imported stuff relevant to morphisms from trac_11111-finite_dimensional_modules-nt.patch
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 10 years ago

Changed commit from 47e0eb9 to 553c5de

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 10 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

553c5de8678: Imported module_morphism_function_extend-fh.patch
nthiery commented 10 years ago

Dependencies: 10668

nthiery commented 10 years ago

Description changed:

--- 
+++ 
@@ -1,8 +1,6 @@
-The upcoming patch in the Sage-Combinat queue implements:
+This ticket implements:
 - inverses for morphisms of finite dimensional vector spaces
 - tensor products of morphisms
-
 and improves:
 - triangular morphisms over base rings

-At this occasion, it starts a bit of cleanup in the category framework for homsets, fixing some known issues (failing _test_category).
nthiery commented 10 years ago

Changed dependencies from 10668 to #10668

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 10 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

15cd16f8678: a CombinatorialFreeModule is FiniteDimensional as soon as the index set is in Sets().Finite()
815b8268678: add support for the matrix of a matrix on the right + improvements to the documentation
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 10 years ago

Changed commit from 553c5de to 815b826

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 10 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

ac38eda10668: trivial ReST fix
dc5fc3dMerge branch 'categories/morphism-methods-10668' into categories/module-morphisms-8678
21bb24c8678: fixed doctests: (triangular) module morphisms now inherit properly from categories
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 10 years ago

Changed commit from 815b826 to 21bb24c

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 10 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

eaa56bc16340: super_structure_categories -> all_structure_super_categories
afc9724Merge branch 'develop' into categories/full-subcategories-16340
21bf60aMerge branch 'categories/full-subcategories-16340' and '6.3beta5' into categories/morphism-methods-10668
442161eMerge branch 'categories/morphism-methods-10668' and '6.3 beta5' into categories/module-morphisms-8678
838bb3f10668: super_structure_categories -> all_structure_super_categories
9de890910668: super_structure_categories -> all_structure_super_categories
0b1810bMerge branch 'categories/morphism-methods-10668' into categories/module-morphisms-8678
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 10 years ago

Changed commit from 21bb24c to 0b1810b

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 10 years ago

Changed commit from 0b1810b to b62ebe9

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 10 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

b62ebe98678: trivial ReST fix
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 10 years ago

Changed commit from b62ebe9 to 8b971f4

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 10 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

8b971f48678: bug fix and doctests for CombinatorialFreeModule being automatically finite dimensional
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 10 years ago

Changed commit from 8b971f4 to 494da74

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 10 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

494da748678: trivial ReST fix
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 10 years ago

Changed commit from 494da74 to cb5a236

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 10 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

cb5a2368678: trivial doctests fix (more categories are finite dimensional now)
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 10 years ago

Changed commit from cb5a236 to aa7fe1d

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 10 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

aa7fe1d8678: noted known pickling issue
nthiery commented 10 years ago

Work Issues: failing test with steenrod and quiver algebras

nthiery commented 10 years ago

Description changed:

--- 
+++ 
@@ -4,3 +4,4 @@
 and improves:
 - triangular morphisms over base rings

+Declares CombinatorialFreeModule indexed by a finite set as being finite dimensional.
nthiery commented 10 years ago
comment:20

Now mosts tests pass. The remaining failing ones are because of some finite dimensional algebras over a finite field become finite, hence finite semigroups. And currently finite semigroups are automatically made into enumerated sets using their generators; however those generators are not always available.

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 10 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

445c9258768: Fixed doctests
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 10 years ago

Changed commit from aa7fe1d to 445c925

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 10 years ago

Changed commit from 445c925 to 8054997

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 10 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

93273a7Merge branch 'u/nthiery/categories/full-subcategories-16340' of trac.sagemath.org:sage into public/categories/full_subcategories-16340
edb29e6Fixed trivial doctest failures.
99a8eb1Merge branch 'public/categories/full_subcategories-16340' of trac.sagemath.org:sage into categories/full-subcategories-16340
8bc456cMerge branch 'master=6.3' into categories/full-subcategories-16340
56e982eMerge branch 'categories/full-subcategories-16340' and 6.3 into categories/morphism-methods-10668
016cd16#16340: Revert ReST typo fix in ell_curve_isogeny.py to avoid conflict with other ticket handling it
d147678Merge branch 'develop=6.4.beta0' into categories/morphism-methods-10668
8054997Merge branch 'categories/morphism-methods-10668' into categories/module-morphisms-8678
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 10 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

16acc6c8678: complete proofreading
a2a16148678: removed explicit doctest:xxx: source line number from a doctest
737a8f016340: improved warnings about the current limitation of the model
282ac4e16340: fixed typos reported by Darij
1e4418fMerge branch 'develop' into categories/full-subcategories-16340
314ee44Merge branch 'categories/full-subcategories-16340' into categories/module-morphisms-8678
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 10 years ago

Changed commit from 8054997 to 314ee44

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 10 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

69070248678: trivial doctest update after merge with develop
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 10 years ago

Changed commit from 314ee44 to 6907024

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 10 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

98521738678: rewrote a few tests introduced by #16296 so that they do not depend on the number of axioms defined in Sage
6136990See discussion on: https://groups.google.com/d/msg/sage-devel/IT_gI_cx0co/QhxdAZeaJzMJ for details.
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 10 years ago

Changed commit from 6907024 to 6136990

tscrim commented 10 years ago
comment:27

From the diff, you've accidentally removed the i += 1, so it should run forever (provided the 0th component is non-trivial). Ah what I wouldn't give for a python builtin do-while loop...

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 10 years ago

Changed commit from 6136990 to ce2a56b

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 10 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

ce2a56b8678: oops, restored accidently deleted increment
bc9eee3a-171b-423e-8ec5-1c11eaa42e98 commented 10 years ago

Changed branch from u/nthiery/categories/module-morphisms-8678 to u/virmaux/categories/module-morphisms-8678

bc9eee3a-171b-423e-8ec5-1c11eaa42e98 commented 10 years ago
comment:30

Humph, so two points:

1- The last push correct a bug in TriangularModuleMorphism with on_basis.

2- I did not know that my push would have change the branch (but I should as it is a 'private' one) and do not know how to replace back the right branch, which is u/nthiery/categories/module-morphisms-8678. Sorry for the noise :s

At least, if my correction is wrong it should be very easy to reset :)

New commits:

0b4b010#8678: fixed on_basis in TriangularModuleMoprhism
bc9eee3a-171b-423e-8ec5-1c11eaa42e98 commented 10 years ago

Changed commit from ce2a56b to 0b4b010

nthiery commented 10 years ago

Changed branch from u/virmaux/categories/module-morphisms-8678 to u/nthiery/categories/module-morphisms-8678

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 10 years ago

Changed commit from 0b4b010 to 9bb4b48

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 10 years ago

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

d8a8373Fixing some typos
75615b510668: trivial doctest updates
d5d3a9710668: improved description of the HomsetsOf class
5416ba0Add a note on the MRO used for Homset._abstract_element_class
23639a9Fix more typos
02a6a8a10668: fixed representation of the category of endsets
477d38110668: Homsets.Endset.super_category -> extra_super_category + documentation
877bfdb10668: fix: Modules.EndCategory -> Modules.Homsets.Endset + made it functional: endsets of modules are algebras
f86824e10668: documentation for HomsetsCategory.category_of + fixed typo in doctest nearby
9bb4b488678: merge in #10668, including develop=6.4 beta4