sagesharp / foss-heartbeat

(Unmaintained) FOSS Heartbeat analyses the health of a community of contributors. :heartbeat:
https://sarahsharp.github.io/foss-heartbeat/
Other
315 stars 38 forks source link

Fix merger over count in rust-lang/rust #29

Open sagesharp opened 8 years ago

sagesharp commented 8 years ago

rust-lang/rust has a bot called bors, which will test the pull request against the CI system, and merge it if it passes. We attempt to attribute the merge of the pull request to both bors and the person who issued the command to bors.

ghcategorize.py appendReviewers() makes some bad assumptions:

We need to be able to figure out whether bors actually merged the pull request, and back track to figure out who was the last person to issue a command to bors.

Further, bors can merge starting from a specific commit. I'm not sure whether people ever merge part of a pull request but not all of a pull request. ??? Would need to talk to the rust folks to understand their usage cases.

I'll mark the place in the code where this needs to get fixed.