sagesharp / foss-heartbeat

(Unmaintained) FOSS Heartbeat analyses the health of a community of contributors. :heartbeat:
https://sarahsharp.github.io/foss-heartbeat/
Other
315 stars 38 forks source link

ghcategorize.py: Remove comments from submitters #39

Open sagesharp opened 7 years ago

sagesharp commented 7 years ago

At least in the facebook/react data I have, I noticed that one comment from the author of a pull request got put into the reviewers.txt, which is incorrect. reviewers.txt should only contain comments from other users on the submitter's pull request.

The file I noticed that was included was facebook/react/issue-114559118/comment-153236130.json, which is a comment by the user ali, who submitted the pull request. This could explain the odd statistics I've been seeing with ghwordhypothesis.py. Maybe submitters are thanking maintainers for merging their pull requests and that's adding false positives to the 'thanked' submitter count?

willingc commented 7 years ago

Good catch.