sahana / vesuvius

Sahana Vesuvius
http://sahanafoundation.org/products/vesuvius/
MIT License
24 stars 27 forks source link

Resource Pages Translate view WYSIWYG editor is displayed too low #28

Closed ravihansa3000 closed 10 years ago

ravihansa3000 commented 10 years ago

The WYSIWYG editor given when attempting to translate a Resource Page is shown towards the middle of the left text body when translating a page which has a large amount of content. This needs to be brought to the top.

Reproduction steps:

  1. Go Administrator->Resource Pages.
  2. Select Translate on one of the pages.
  3. The WYSIWYG editor is displayed low down, it is visible only after scrolling the page.

Imported from Launchpad using lp2gh.

ravihansa3000 commented 10 years ago

(by sneha-22-7) Editing the theme/lpf3/sahana.css has fixed this. I changed a few of the div attributes like the rezLog and mainTable to get it fixed. Also adding a horizontal scrollbar can help.

ravihansa3000 commented 10 years ago

(by gurutharshan) I have add javascript function to scroll inside rez_perform_translate() calls in /mod/rez/xajax.inc file It works fine for me.. check and tell me if u need further improvements..:)

ravihansa3000 commented 10 years ago

(by sneha-22-7) this is the sahana.css file which i have edited. please let me know if i am moving in the right direction

ravihansa3000 commented 10 years ago

(by rasade88) Sneha, can you do a bzr diff on your codebase and generate a patch like Guru has done?

Guru, I'll take a look at your patch tonight. Thanks!

ravihansa3000 commented 10 years ago

(by sneha-22-7)

ravihansa3000 commented 10 years ago

(by rasade88) The above patches do not fix the bug. Please test your code with enable_locale set to 'true' in sahana.conf and changing around the locale in the Resource Pages administration section.

ravihansa3000 commented 10 years ago

(by sneha-22-7) I slightly changed the sahana.css file again. I set the enable_locale to true in sahana.conf. Didn't add any javascript to the xajax.inc. Its working for me, ie the WSIWYG editor is not displayed low anymore, i changed the default height and added a scrollbar.

ravihansa3000 commented 10 years ago

(by thevisheshone)

ravihansa3000 commented 10 years ago

(by thevisheshone) I tried changing the xajax.inc file itself in vesuvius/mod/rez. Overriding the css style didn't work for some reason. I used the older valign attribute and it works.

ravihansa3000 commented 10 years ago

(by thevisheshone) Incase the way I took the patch was wrong above, I'm attatching the xajax.inc file here. It goes inside vesuvius/mod/rez/

ravihansa3000 commented 10 years ago

(by thevisheshone) I'm sorry, the above fix used valign. It's depreciated. The css override does work. This patch fixes it overriding the default css values. The fix is for the xajax.inc file in vesuvius/mod/rez/ Please use this patch.

ravihansa3000 commented 10 years ago

(by thevisheshone) the source file.

ravihansa3000 commented 10 years ago

(by gurutharshan) Vishesh, ur fix works for me too.. anyway i added patch for that..

ravihansa3000 commented 10 years ago

(by gurutharshan) Vishesh, ur fix works for me too.. anyway i add patch for that..

ravihansa3000 commented 10 years ago

(by thevisheshone) what?! so the way I added the patch was wrong?

ravihansa3000 commented 10 years ago

(by thevisheshone) Ok, I'm sorry the way I created the patch file was wrong, anyways, here goes.

ravihansa3000 commented 10 years ago

(by sneha-22-7) Apparently adding a scrollbar was not the only solution. The editor was still being displayed low. So i again edited the xajax.inc file. Now its perfect. :)

Thanks Vishesh for pointing out that changing the .css file does not work all the time.

ravihansa3000 commented 10 years ago

(by thevisheshone) @sneha, can you elaborate on the difference between your patch and mine? Other than using vertical align, I just also extended the width to 100% as I didn't see any point in keeping the width 90%.

ravihansa3000 commented 10 years ago

(by sneha-22-7) i also added a scrollbar to the wsywig section. to make the visibilty better. then i added vertical align. no other changes.

On Mon, Apr 29, 2013 at 12:48 PM, Vishesh S Hiremath <

ravihansa3000 commented 10 years ago

(by rasade88) Committed Sneha's fix as she submitted first.

Vishesh, yours works as well, so you get kudos too.

Thanks!