sahilsehwag / pluralsight-downloader-chrome-extension

[WIP] A chrome extension to download and track Pluralsight courses. 😈
The Unlicense
301 stars 67 forks source link

Key Binding Not working #27

Closed afeso closed 2 years ago

afeso commented 3 years ago

Hello,

I've Successfully installed the app in Chrome and activated it, but the icon remains grey.

I've tried the key bindings on various videos, but nothing seems to happen.

Is there any additional setup that's needed?

gcollis1 commented 3 years ago

Also not working for me

sahilsehwag commented 3 years ago

@afeso @gcollis1 Hey can you share the steps you followed to install the extension?

gcollis1 commented 3 years ago

download zip unzip

Alternatively, open this page by clicking on the Extensions menu button and selecting Manage Extensions at the bottom of the menu. Enable Developer Mode by clicking the toggle switch next to Developer mode. Click the Load unpacked button and select the extension directory nothing happens when i press e whilst watching a video

sahilsehwag commented 3 years ago

@gcollis1 @afeso I can download the content with the keypress, Its working fine NOTE: One think I should specify is that you can download the videos/course when you are on video player page of the course( which open when we click on some video in the course and video player page is open where we can see all the course modules and videos in the menu on the right and current video is playing in the left or center

We have added an extension UI to do the same actions, Have you tried downloading the video using buttons that are shown when we click on the extension icon in chrome bar? Can you try that and let me know? The reason I am asking this is because in the near future I will remove the shortcuts, and everything will be done through extension popup.

Alternatively you can check if the extension is working or not by

  1. Right click on page where video player is open
  2. Select the Inspect option
  3. A window will open, Go to the Console tab
  4. There will be a dropdown shown with a select value of Top, Can you click on that select the option with the name PluralsightCourseDownloaderExtension
  5. Now try the shortcuts like e to enable and c to download the course
  6. Can you take the screenshot of whatever that's being printed there and share the screenshots here
shakaibakhtar commented 3 years ago

image

sahilsehwag commented 3 years ago

@shakaibakhtar Did you stop the downloading yourself, or did it happen on its own?

If it happened on its own, Can you tell how did you started the downloading (using keyboard shortcut(which keyboard shortcut) or using extension's UI?

shakaibakhtar commented 3 years ago

It stopped on its own. on page load I pressed e and then pressed c, then the text in the Screenshot attached in above comment was printed in the console and download did'nt start.

amitkumar2283 commented 3 years ago

I am facing a similar issue.

  1. What I have down till now:

The plugin is installed and looks like this: image

Clicking on the plugin does not open any UI (Not sure if it is supposed to) image

  1. What is the behavior that I am experiencing: When I play a pluralsight video, pressing 'e' does not provide any feedback, hence I am not sure if it is working or not. Pressing 'c' just enables/disables captions and does nothing else.

  2. More Details: here is the console grab: image

sahilsehwag commented 3 years ago

Hey, This seems like a quite older version of extension, in the latest changes we have UI popup which opens when we click on the extension icon, and now we have pluralsight icon as the extension icon (https://github.com/sahilsehwag/pluralsight-downloader-chrome-extension/blob/master/images/screenshot-1.png)

Can you install the extension using latest changes, download the code as zip, unzip it, then enable developer mode in chrome, and finally load the extension using "Load Unpacked" button in "Manage Extension" page.

As mentioned above, in future I will be removing the keybindings, and extension popup will be the preferred way to use the extension.

amitkumar2283 commented 3 years ago

Thank you for the blazingly fast response. I have installed 0.3 alpha; Is this not the latest?

sahilsehwag commented 3 years ago

Since this is still in its infancy, therefore a lot of changes are done without updating the README file, or adding new releases, will do those chores when this becomes v1.0.0

To get the latest changes, follow the steps I mentioned above

amitkumar2283 commented 3 years ago

the lastest codebase works fine. Thanks a lot

DenisMtfl commented 3 years ago

Its not working anymore.

ogeeDeveloper commented 2 years ago

does not work when in press c it enables and disables subtitles

chrispaivacwb commented 2 years ago

its not working for me.

pluralsight_error

sahilsehwag commented 2 years ago

Hey keybindings are not supported in latest versions, in latest version we have UI/popup to do the same actions.