search

sahilsehwag / pluralsight-downloader-chrome-extension

[WIP] A chrome extension to download and track Pluralsight courses. 😈
The Unlicense
301 stars 67 forks source link

Countdown timer freezing #56

Open recifecode opened 2 years ago

recifecode commented 2 years ago

Sometimes it happens to get the download queue stopped, then when I click the extension, I notice that countdown timer (shown as "STATUS") stucks.

Not sure about the root cause, but I believe it happens when you keep using the Chrome window, opening and closing some others tabs, which is something completely necessary to organize your queue of courses.

image

recifecode commented 2 years ago

I think it's related to the browser tab closing.

If I start the extension by downloading Course A and open other courses in new tabs, the functions (lets say like that), keep going under the course A tab instead of executing in a wide scope (valid for other tabs). That's my guess for the timer getting stopped and download queue consequently. It happens when we close the tab that was the originator of the funcion call.

recifecode commented 2 years ago

BTW, the uncaught error below is related to the timer and keeps incrementing the number of errors only in the console within the tab that started the 'download' while the extension is busy downloading videos:

Uncaught (in promise) Error: The message port closed before a response was received. (course-player:1)

arminanton commented 1 year ago

I noticed that behaviour when I left the extension downloading the stuff and went to do something else in other tab or in another app (outside chrome). I suspect that it froze due to the memory garbage collector that chrome has to better manage your memory consumption.. Could also be that the cookie token expired and needed to be renewed by loading a new video to play on the site. For me, the only way around this was to reload the page and begin a new course download using e and c keys, which would then re-download all the files that were previously downloaded. (perhaps if we had a way to check if the file already exists and if the filesize matches).. not sure.

ai1000ws commented 1 year ago

I always get stuck in the same way with the last two to three videos. I've tried closing all windows, enabling and disabling the addons, attempting possible keyboard shortcuts, and changing the options, but nothing seems to work. I'm just wondering if there are any suggestions. Re-downloading is an option, but it's becoming complicated and always creates duplicate files, making it a time-wasting endeavor so far.