Pluralsight udpated its player framework today, the extension does not work, would it be possible to also update it? Very much appreciated.

sclihua commented 1 year ago

Nothing works, tried the shortcut and clicked buttons, not work for me. It will be highly appreciated if the extension can be updated. Thanks a lot.

sahilsehwag commented 1 year ago

@sclihua

I am working on a really cool complete rewrite of the project.
Building it from scratch, it will take a bit longer for it to be available for everyone
As for player framework being updated, I checked all the things that should make this work are as it is and in place, so everything should work as it was working before
As for keyboard shortcuts, keyboard shortcuts were removed in favour of popup, which is easier for everyone to use
Can you share how you installed and setup everything?
What are the errors you are getting in extension tab inside devtools?
Maybe this can help you

sclihua commented 1 year ago

Thanks a lot for replying to me. @sahilsehwag

Very good to know you are working on a wonderful new version, look forward to it.

To your questions: I installed the extension by loading the unpacked, and then just tried the way referred to, by changing the crx and drg-n-drop. Both did not work. By the way, the extension was working this morning, and then Pluralsight changed the player. Now the link becomes https://app.pluralsight.com/ilx/video-courses/clips/bb88f8f1-42e3-4656-9e53-75edf9c4db6d when the course is playing.

F12 dev tools gave error like this: Keypress: 86 script.js:123 [PluralsightCourseDownloader]:[STATUS]: Downloading course from now on ... script.js:123 [PluralsightCourseDownloader]:[STATUS]: Fetching course information... bb88f8f1-42e3-4656-9e53-75edf9c4db6d:1 Uncaught (in promise) SyntaxError: Unexpected end of JSON input at JSON.parse () at HTMLDocument. (script.js:738:28) at HTMLDocument.dispatch (jquery.slim.min.js:2:41964) at v.handle (jquery.slim.min.js:2:39983) at Object.trigger (jquery.slim.min.js:2:62230) at HTMLDocument. (jquery.slim.min.js:2:62825) at Function.each (jquery.slim.min.js:2:2765) at w.fn.init.each (jquery.slim.min.js:2:1438) at w.fn.init.trigger (jquery.slim.min.js:2:62801) at script.js:669:15

Thanks.

sahilsehwag commented 1 year ago

@sclihua

Seems like they are AB testing this, since I am getting the old player
But I am able to access the new player, using the link you provided
I can see that this will definitely fail and changes will be required to add support for getting course TOC in this new flow
If you or someone is interested in fixing this, they can submit the PR to add support for the new flow as well.
As for me, I'll add the support in the newer version that I am building from scratch
As of now, I am not sure, when will this new version will be finished or at least publishable
Something you can try
- Just like how I am able to access the new player using the URL you provided, maybe you can try playing the course by manually entering the URL in old player format
- If it works, then I think you should be able to download course
- For the above video URL you provided it would be https://app.pluralsight.com/course-player?clipId=bb88f8f1-42e3-4656-9e53-75edf9c4db6d

sclihua commented 1 year ago

@sahilsehwag

I tried the old URL, it automatically navigates to the newer one. It seems the new player is enforced in my area. Then do not bother with it, I can live with the online version and wait for your next update.

Thanks.

sahilsehwag commented 1 year ago

@sclihua

1 last thing you can try is VPN to access a different region.
I am operating from India, maybe you can try Asian regions

puyaalexxx commented 1 year ago

the same issue happens to me

siwanian commented 1 year ago

Same issue with me too. Nothing is working :(

siwanian commented 1 year ago

@sahilsehwag let me know if you need any help in fixing this extension??

SagarS456 commented 1 year ago

Pluralsight has 2 differnet layout in one layout inside window.Next_DATA "tableofcontents" data is present and in other layout window.Next_DATA is blank. The code is in script.js file line no 738

mnaeem600 commented 11 months ago

@sahilsehwag How much of an effort it is to fix the curret extension to look at new TOC? I can try to have a look if you can give me some pointer on where to correct this issue.

Thanks

6ebeng commented 11 months ago

Already fixed, it need approve my pull request.

mnaeem600 commented 11 months ago

@6ebeng beng Where to find the fixed version? Thanks

6ebeng commented 11 months ago

check this out https://github.com/6ebeng/pluralsight-downloader-chrome-extension-plus

mnaeem600 commented 11 months ago

Hi Tishko, It does not work. The url in web browser is

https://app.pluralsight.com/ilx/video-courses/

Where does the changes need to be made in script.js?

Thanks

From: Tishko Rasoul @.> Sent: 28 December 2023 14:10 To: sahilsehwag/pluralsight-downloader-chrome-extension @.> Cc: Nasir @.>; Comment @.> Subject: Re: [sahilsehwag/pluralsight-downloader-chrome-extension] Pluralsight udpated its player framework today, the extension does not work, would it be possible to also update it? Very much appreciated. (Issue #67)

check this out https://github.com/6ebeng/pluralsight-downloader-chrome-extension-plus

— Reply to this email directly, view it on GitHubhttps://github.com/sahilsehwag/pluralsight-downloader-chrome-extension/issues/67#issuecomment-1871210628, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AJUNHTMP7ZP7LYPVWORF6BTYLV4SPAVCNFSM6AAAAAA7BW4C4GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZRGIYTANRSHA. You are receiving this because you commented.Message ID: @.**@.>>

siwanian commented 11 months ago

@6ebeng https://github.com/6ebeng/pluralsight-downloader-chrome-extension-plus

gives 404 error :(

siwanian commented 10 months ago

@6ebeng any idea how to download your extension?? it shows 404 error :(

mnaeem600 commented 10 months ago

Hi siwanian, It works. I got a copy. Send me your PM.

Thanks

From: siwanian @.> Sent: 23 January 2024 05:28 To: sahilsehwag/pluralsight-downloader-chrome-extension @.> Cc: Nasir @.>; Comment @.> Subject: Re: [sahilsehwag/pluralsight-downloader-chrome-extension] Pluralsight udpated its player framework today, the extension does not work, would it be possible to also update it? Very much appreciated. (Issue #67)

@6ebenghttps://github.com/6ebeng any idea how to download your extension?? it shows 404 error :(

- Reply to this email directly, view it on GitHubhttps://github.com/sahilsehwag/pluralsight-downloader-chrome-extension/issues/67#issuecomment-1905317632, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AJUNHTO5CHEKPXTUGCO5MXLYP5C5LAVCNFSM6AAAAAA7BW4C4GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBVGMYTONRTGI. You are receiving this because you commented.Message ID: @.**@.>>

dmitry-donskoy commented 10 months ago

mnaeem600 Could you, plese, send me your corrected extension on e-mail ?! Its - vernikov101@gmail.com Thank you.

Hi siwanian, It works. I got a copy. Send me your PM. Thanks From: siwanian @.> Sent: 23 January 2024 05:28 To: sahilsehwag/pluralsight-downloader-chrome-extension @.> Cc: Nasir @.>; Comment @.> Subject: Re: [sahilsehwag/pluralsight-downloader-chrome-extension] Pluralsight udpated its player framework today, the extension does not work, would it be possible to also update it? Very much appreciated. (Issue #67) @6ebenghttps://github.com/6ebeng any idea how to download your extension?? it shows 404 error :( - Reply to this email directly, view it on GitHub<#67 (comment)>, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AJUNHTO5CHEKPXTUGCO5MXLYP5C5LAVCNFSM6AAAAAA7BW4C4GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBVGMYTONRTGI. You are receiving this because you commented.Message ID: @.**@.>>

sclihua commented 10 months ago

.

g-h-mac commented 10 months ago

@mnaeem600

Hi siwanian, It works. I got a copy.

Can you please share your working version?

Thanks

sahilsehwag commented 10 months ago

@6ebeng @mnaeem600

If you guys can provide the PR I will merge it into the master branch, that should suffice until I finish up the rewrite
I have suggested some changes in the PR by @6ebeng (https://github.com/sahilsehwag/pluralsight-downloader-chrome-extension/pull/69#issuecomment-1922337105)
The logic is simple, for reference please check the PR by @6ebeng
If __NEXT_DATA is available then use it to get TOC (existing flow)
Else if its undefined get the TOC from the new API endpoint to fetch the TOC (updated flow)
Need both since we need to support both of the flows

g-h-mac commented 10 months ago

@dmitry-donskoy @mnaeem600 : Following the link @sahilsehwag provided, I see that 6ebeng deleted his patch-1 branch 3 months ago. But if you click on the "Files Changed" tab, it appears his partially completed work still exists as a diff: https://github.com/sahilsehwag/pluralsight-downloader-chrome-extension/pull/69/files

Caroga commented 9 months ago

Hi there! I am excited about this rewrite and am looking forward to being able to use this extensions. Is there anything you need help with at the moment?

g-h-mac commented 9 months ago

@Caroga

Is there anything you need help with at the moment?

Yes. Please look at the PR at https://github.com/sahilsehwag/pluralsight-downloader-chrome-extension/pull/69#issuecomment-1922337105 and you will see that @darjimahesh commented there recently that the proposed changes make the extension into a working product. I know this is a deleted PR as 6ebeng deleted his work from his github account (404), but the proposed changes are still visible at https://github.com/sahilsehwag/pluralsight-downloader-chrome-extension/pull/69/files

Please apply these changes to a copy of master, test it, and if you agree it is working, please make a new PR that sahilsehwag can merge into master.

Thanks for your interest in helping.

Caroga commented 9 months ago

I will look into this 👍🏻 Expect to have this done during the weekend though.

Caroga commented 9 months ago

I can confirm that the files are being downloaded. The extensions has downloaded 4 videos, after which it stopped. The timeout (waiting xx:xx) time stopped counting down. After restarting the browser I found the following error in my developers console when retrying:

tanushshukla commented 9 months ago

I think I've managed to fix the issue. What course are you trying? I can test and create a PR.

I'm just doing more testing right now.

dmitry-donskoy commented 9 months ago

I think I've managed to fix the issue. What course are you trying? I can test and create a PR.

I'm just doing more testing right now.

If you can, please, download this course ! https://app.pluralsight.com/library/courses/spring-framework-6-building-java-web-applications/table-of-contents

Caroga commented 9 months ago

@tanushshukla I was downloading a course on kubernetes but the mentioned course above is as good as any. I find it weird that the download was working but broke later on. I thought maybe a anti-download mechanism was triggered on pluralsight. Were you able to download an entire course?

tanushshukla commented 9 months ago

I think I've managed to fix the issue. What course are you trying? I can test and create a PR. I'm just doing more testing right now.

If you can, please, download this course ! https://app.pluralsight.com/library/courses/spring-framework-6-building-java-web-applications/table-of-contents

I had to make a small adjustment but its working fine now.

@tanushshukla I was downloading a course on kubernetes but the mentioned course above is as good as any. I find it weird that the download was working but broke later on. I thought maybe a anti-download mechanism was triggered on pluralsight. Were you able to download an entire course? Yes, its weird that it stopped mid way. That did not happen to me. The courseId and courseURL is different based on new and old URL.

I can test with the specific course if you can give me and test it.

Will raise a PR soon.

6ebeng commented 9 months ago

be patient I'm about to build something different :)

tanushshukla commented 9 months ago

be patient I'm about to build something different :)

that looks really sick!

Caroga commented 9 months ago

This is the course I was trying to download. I was able to get the second section, chapter 3 (03. Introducing the Kubernetes API - Objects and API Server). I was getting errors with chapter 4.

tanushshukla commented 9 months ago

This is the course I was trying to download. I was able to get the second section, chapter 3 (03. Introducing the Kubernetes API - Objects and API Server). I was getting errors with chapter 4.

It downloaded the whole course. Will raise the PR tonight.

tanushshukla commented 9 months ago

https://github.com/sahilsehwag/pluralsight-downloader-chrome-extension/pull/73 Raised the PR here.

BuldoZZer85 commented 9 months ago

73 Raised the PR here.

With the PR extension had started to work. Already downloaded 3 courses and 1 is on the way.

Thanks community!

dmitry-donskoy commented 9 months ago

73 Raised the PR here.

That`s strange, I can't configure this script in my browser. I copied the new script completely, replaced the old code in the extension folder, but nothing happens. Silence !

BuldoZZer85 commented 9 months ago

On my experience the extension sometimes didn't work on a browser like Vivaldi. I didn't find the reason because it started work on new Brave brower after reinstalling the extension.

sahilsehwag commented 9 months ago

Merged #73 by @tanushshukla. This should be working now. Closing this issue for now.

5aj031 commented 8 months ago

@sahilsehwag @tanushshukla Thanks for the effort guys, but am I missing something or this last merge doest solve the issue? I'm trying to download the following course, but it is not working :/

https://app.pluralsight.com/ilx/aws-certified-cloud-practitioner-(clf-c02)-cloud-foundations-and-compute/4c287c6d-13d9-40cf-a98e-526acb973aa2/5069ba76-92ed-413c-8570-b69084560410

Keypress: 101 script.js:699 
script.js:125 [PluralsightCourseDownloader]:[STATUS]: Enabled the extension bindings. script.js:699 
Keypress: 99 script.js:125 
[PluralsightCourseDownloader]:[STATUS]: Downloading course from the beginning ... script.js:125 
[PluralsightCourseDownloader]:[STATUS]: Fetching course information...script.js:747 
url: https://app.pluralsight.com/ilx/aws-certified-cloud-practitioner-(clf-c02)-cloud-foundations-and-compute/4c287c6d-13d9-40cf-a98e-526acb973aa2/5069ba76-92ed-413c-8570-b69084560410
script.js:760  
Could not extract courseId from URL

sahilsehwag / pluralsight-downloader-chrome-extension

Pluralsight udpated its player framework today, the extension does not work, would it be possible to also update it? Very much appreciated. #67

73 Raised the PR here.

73 Raised the PR here.