search

sahlberg / libnfs-python

Python bindings for libnfs
GNU Lesser General Public License v2.1
64 stars 34 forks source link

Implemented binary ('b') mode for nfs files. #6

Closed fredrik-eriksson closed 9 years ago

fredrik-eriksson commented 9 years ago

Hi,

I've implemented binary mode for the NFSFH object to make this library easier to use in python 3. The NFSFH object should still be fully backward compatible. Unfortunately, the mapped C-API is not compatible for the following functions:

The buffer argument for these functions now requires the bytearray type instead of a string, both in python2 and python3. I don't know if this is a deal breaker, but any feedback is welcome :)

sahlberg commented 9 years ago

I think the c-api could / should probably be removed at some stage and the module should only offer a python api.