sahlberg / pop-fe

Python script to automate the process of fetching boxart and installing PS1 games (onto your PSP/VITA/PS2/PS3)
135 stars 13 forks source link

PSP GUI possible Bug + Misc #43

Closed wad11656 closed 9 months ago

wad11656 commented 9 months ago

image

pop-fe PSP:

  1. I don't think changing the GameID field changes the GameID.
  2. When EBOOT is finished being created, it says "PKG" instead of "EBOOT" (Who cares but just fyi)
  3. Does the "Theme" affect anything in the PSP version? If so, can you make it show you a live preview when you select a theme?
  4. After a random PIC1 is pulled from psxdatacenter, can you add the ability to click the PIC1 thumbnail to cycle through the different options?

Thank you, this is nifty and super surprising that it exists

P.S. I'm also curious where you get PIC0 from? In the case of NFSIII, as seen in my pic, it perfectly pulls in a beautiful transparent game logo. Does that come from psxdatacenter too? I didn't see it there. Some games don't have the beautiful transparent logo

sahlberg commented 9 months ago

Done, except of the PIC1 rotation suggestion. the defaults from psxdatacentre images are all bad so click to rotate will just rotate between bad pictures. And we should not encourage the defaults.

What we need to have is curated links to good images. Best is if you send me a pull request with updates in gamedb.py to good art, or less good is if you just tell me which games you need art for and I will try to find and update gamedb with it.

The icons that are pulled are usually from gamedb.py https://github.com/sahlberg/pop-fe/blob/master/gamedb.py

Only if nothing is found for the game in this db will pop-fe go to psxdatacentre and use it. This is the source of last resort. Most of the logos I use are from here: https://gamesdb.launchbox-app.com/games/images/135551-ecsaform

sahlberg commented 9 months ago

I have added a better image for PIC1 for hot pursuit. Try regenerating it and it should look better.

wad11656 commented 9 months ago

Thank you I'm eager to try with the new Windows exe release

sahlberg commented 9 months ago

You can find the most recent build here: https://github.com/sahlberg/pop-fe/actions/runs/6282602543 Under the ACTIONS tab there will be an automatic new build for every push.

wad11656 commented 9 months ago

I'm dumb and don't know how to get the UI (pop-fe-psp.ui?) working with the newly downloaded pop-fe-psp.exe from the "Artifact" .zip file on that page, which didn't seem to come packaged with the UI part? sorry for my dumbness.

I know this issue thread isn't the right place to ask but I didn't know if it justified opening a new Issue...I just wanted to quickly ask if you were documenting the game name/bug fix(es) of each ppf in the ppf folder?

Something like:

SLUS12345.ppf - FFVII (NTSC-U) - Fixes bug with door on level 3.
SLUS54321.ppf - Crash Bandicoot (NTSC-U) - Fixes glitch on final boss

(Just to be clear, the ppf files in the ppf folder are all bugfixes, right? And they get automatically applied in pop-fe-psp.ui to any game that matches with that Game ID?) I think it's really cool you've integrated such patches into your program. Where do those ppf patches come from, anyway? Are you personally making any of them yourself?

Edit: Oh you mentioned in your readme your libcrypt ppf list is incomplete so here's my reupload of potentially the whole collection from psxplanet.ru ... : https://archive.org/details/lib-crypt-ppf-patches

Edit2: FWIW I found that the first time I got random pics pulled from psxdatacenter it looked dope. Which is why I thought cycling through the options would make for a good interim solution, in case psxdatacenter has some potentially decent-looking image combinations available. But I see your perspective.

sahlberg commented 9 months ago

I will try to test the pop-fe-psp.ui later once I get access to a windows machine to test with.

The PPFs, we rarely need them for when creating EBOOTS or PKGs for PSP/PS3 as they both have special ways to feed things like 'libcrypt' to their emulators (semi-recently discovered that both of these can take both the 'magic-word' that solves libcrypt but also can take a special form of sbi files, which we can now regenerate. Both these go into the EBOOT or ISO.BIN.EDAT and solves that for both platforms. This solves most of the incompatibilities.

We also recently learned how to add "config" commands to the emulators, the ones on ps3 a few weeks back, and the ones on psp just a few days ago, so research is still going on by the folks that know those things. I don't, I just add the "config" data that they tell me to add to fix certain games. Some games do need PPF patching and I also just add these when people report issues and the guys that know this stuff debug the issue and create a ppf and give it to me.

A good place to find this process is this thread: https://www.psx-place.com/threads/ps1_netemu-external-configs-and-ad-hoc-params.41504/ Read through it. This is where a user on psx-place, mrjaredbeta, works with and annouces new configs to fix games that he and kozarov debugs and fixes. For now, ypou can report games that have issues on the ps1_netemu emulator there and those guys may be able to find a fix, either a config setting or a ppf and then I will add it to pop-fe.

There are a whole bunch of PPFs that are just for fixing libcrypt. These are only used for platforms where I can not fix it properly, i.e. create a SBI file for retroarch, or add a SBI-file-equivalent into the EBOOT/ISO.BIN.EDAT for PSP/PS3. There is a small number of PPFs that have been added to fix issues for games where we can not solve with configs, these are all linked from the table 'ppf_fixes' in the file gamedb.py. These are all developed and created by the folks on that psx-place thread above.

sahlberg commented 9 months ago

Try the latest artefacts, the pop-fe-psp.ui issue shoudl be fixed now.