search

sai3010 / Typesense-Kubernetes-Operator

An operator to manage Typesense clusters on Kubernetes
Apache License 2.0
45 stars 11 forks source link

Possibility to use Kubernetes secrets instead of clear password #15

Closed fharper closed 3 months ago

fharper commented 7 months ago

Is your feature request related to a problem? Please describe. If using GitOps to deploy this operator, the password in the YAML file will be clearly visible.

Describe the solution you'd like Being able to use Kubernetes Secrets in addition of string for the password.

Describe alternatives you've considered There is none that I can think of.

Additional context I agree that the indexed data for public sites are not critical, still I wouldn't like to have a bad actor screw up my indexes as they can easily retrieve the admin password (API key). It's another story for private information. With that said, even if the gitops repository is private, still not a good practice to have the password committed in it, when it could be in a secret.

pbtrudel commented 5 months ago

+1 on this feature! Since everything we deploy in Kubernetes is in Git, having the password in clear text is not great. This limitation is my only concern right now with using this operator. Would it be possible to implement this?

sai3010 commented 4 months ago

@pbtrudel @fharper Sure I will take it up. Thank you!

sai3010 commented 3 months ago

I am closing this as it is resolved in release 2.1. @pbtrudel @fharper