saicone / OneTimePack

Bungeecord and Velocity plugin that reduces duplicated resource pack requests
MIT License
17 stars 2 forks source link

Protocolize module doesn't detect ResourcePackPush on CONFIGURATION protocol #7

Open nhanledev opened 4 weeks ago

nhanledev commented 4 weeks ago

I enable debug and notice that the plugin does not call onPackPush() on 1.21.1, so this may be the reason that caused the resource pack reload every time I switch the server

Stack: Bungeecord + Protocolize

[11:55:38 INFO]: [/10.0.0.80:59520] <-> InitialHandler has connected
[11:55:38 INFO]: [HibaraMamoru|/10.0.0.80:59520] <-> ServerConnector [hub0] has connected
[11:55:39 INFO] [OneTimePack]: [CONFIGURATION] Packet#read() = ClientboundResourcePackPush{uniqueId='d69238f2-b7ce-30b0-8262-17cd9490f29d', url='http://dev-mc.REACTED.com:10900/generated.zip', hash='f705f974eb2db532676300217b921ebd53f55e82', forced=true, hasPromptMessage=true, promptMessage='{"type":"CompoundTag","value":{"text":{"type":"StringTag","value":"\n"},"italic":{"type":"ByteTag","value":0},"extra":{"type":"ListTag","value":{"type":"CompoundTag","list":[{"text":{"type":"StringTag","value":"REACTED"},"color":{"type":"StringTag","value":"white"}}]}}}}'}
[11:55:39 INFO] [OneTimePack]: [CONFIGURATION] Packet#read() = ServerboundResourcePack{uniqueId='d69238f2-b7ce-30b0-8262-17cd9490f29d', result=3}
[11:55:39 INFO] [OneTimePack]: Saved cached result ACCEPTED from player c9bd2771-a736-35c8-a2a8-2fc1d51fbba9
[11:55:39 INFO] [OneTimePack]: [CONFIGURATION] Packet#read() = ServerboundResourcePack{uniqueId='d69238f2-b7ce-30b0-8262-17cd9490f29d', result=4}
[11:55:39 INFO] [OneTimePack]: Saved cached result DOWNLOADED from player c9bd2771-a736-35c8-a2a8-2fc1d51fbba9
[11:55:40 INFO] [OneTimePack]: [CONFIGURATION] Packet#read() = ServerboundResourcePack{uniqueId='d69238f2-b7ce-30b0-8262-17cd9490f29d', result=0}
[11:55:40 INFO] [OneTimePack]: Saved cached result SUCCESS_DOWNLOAD from player c9bd2771-a736-35c8-a2a8-2fc1d51fbba9
[11:55:45 INFO]: [HibaraMamoru|/10.0.0.80:59520] <-> ServerConnector [s0] has connected
[11:55:45 INFO]: [/10.0.0.80:59520|HibaraMamoru] <-> DownstreamBridge <-> [hub0] has disconnected
[11:55:45 INFO] [OneTimePack]: [CONFIGURATION] Packet#read() = ClientboundResourcePackPush{uniqueId='d69238f2-b7ce-30b0-8262-17cd9490f29d', url='http://dev-mc.REACTED.com:10900/generated.zip', hash='f705f974eb2db532676300217b921ebd53f55e82', forced=true, hasPromptMessage=true, promptMessage='{"type":"CompoundTag","value":{"text":{"type":"StringTag","value":"\n"},"italic":{"type":"ByteTag","value":0},"extra":{"type":"ListTag","value":{"type":"CompoundTag","list":[{"text":{"type":"StringTag","value":"REACTED"},"color":{"type":"StringTag","value":"white"}}]}}}}'}
[11:55:45 INFO] [OneTimePack]: [CONFIGURATION] Packet#read() = ServerboundResourcePack{uniqueId='d69238f2-b7ce-30b0-8262-17cd9490f29d', result=3}
[11:55:45 INFO] [OneTimePack]: Saved cached result ACCEPTED from player c9bd2771-a736-35c8-a2a8-2fc1d51fbba9
[11:55:45 INFO] [OneTimePack]: [CONFIGURATION] Packet#read() = ServerboundResourcePack{uniqueId='d69238f2-b7ce-30b0-8262-17cd9490f29d', result=4}
[11:55:45 INFO] [OneTimePack]: Saved cached result DOWNLOADED from player c9bd2771-a736-35c8-a2a8-2fc1d51fbba9
[11:55:46 INFO] [OneTimePack]: [CONFIGURATION] Packet#read() = ServerboundResourcePack{uniqueId='d69238f2-b7ce-30b0-8262-17cd9490f29d', result=0}
[11:55:46 INFO] [OneTimePack]: Saved cached result SUCCESS_DOWNLOAD from player c9bd2771-a736-35c8-a2a8-2fc1d51fbba9
[11:55:49 INFO]: [HibaraMamoru|/10.0.0.80:59520] <-> ServerConnector [hub0] has connected
[11:55:49 INFO]: [/10.0.0.80:59520|HibaraMamoru] <-> DownstreamBridge <-> [s0] has disconnected
[11:55:49 INFO] [OneTimePack]: [CONFIGURATION] Packet#read() = ClientboundResourcePackPush{uniqueId='d69238f2-b7ce-30b0-8262-17cd9490f29d', url='http://dev-mc.REACTED.com:10900/generated.zip', hash='f705f974eb2db532676300217b921ebd53f55e82', forced=true, hasPromptMessage=true, promptMessage='{"type":"CompoundTag","value":{"text":{"type":"StringTag","value":"\n"},"italic":{"type":"ByteTag","value":0},"extra":{"type":"ListTag","value":{"type":"CompoundTag","list":[{"text":{"type":"StringTag","value":"REACTED"},"color":{"type":"StringTag","value":"white"}}]}}}}'}
[11:55:49 INFO] [OneTimePack]: [CONFIGURATION] Packet#read() = ServerboundResourcePack{uniqueId='d69238f2-b7ce-30b0-8262-17cd9490f29d', result=3}
[11:55:49 INFO] [OneTimePack]: Saved cached result ACCEPTED from player c9bd2771-a736-35c8-a2a8-2fc1d51fbba9
[11:55:49 INFO] [OneTimePack]: [CONFIGURATION] Packet#read() = ServerboundResourcePack{uniqueId='d69238f2-b7ce-30b0-8262-17cd9490f29d', result=4}
[11:55:49 INFO] [OneTimePack]: Saved cached result DOWNLOADED from player c9bd2771-a736-35c8-a2a8-2fc1d51fbba9
[11:55:50 INFO] [OneTimePack]: [CONFIGURATION] Packet#read() = ServerboundResourcePack{uniqueId='d69238f2-b7ce-30b0-8262-17cd9490f29d', result=0}
[11:55:50 INFO] [OneTimePack]: Saved cached result SUCCESS_DOWNLOAD from player c9bd2771-a736-35c8-a2a8-2fc1d51fbba9
naikyys commented 4 weeks ago

Same issue here, not working on 1.21.1

nhanledev commented 4 weeks ago

The behavior of 1.21.1 might be the same as 1.20.2, but I still haven't found the fix for this

naikyys commented 3 weeks ago

The behavior of 1.21.1 might be the same as 1.20.2, but I still haven't found the fix for this

Didn't you find a solution?...

nhanledev commented 3 weeks ago

No, it looks like protocolize on bungeecord is broken, velocity + vpacketevent works great so I am just rebuilding my whole proxy to velocity instead lol

naikyys commented 3 weeks ago

No, it looks like protocolize on bungeecord is broken, velocity + vpacketevent works great so I am just rebuilding my whole proxy to velocity instead lol

Okay, so if I switch to Velocity + vpacketevent, it should be fine?

nhanledev commented 3 weeks ago

Yes, I almost finish my new proxy setup and confirm that it works perfectly. Fortunately, all of my proxy plugins are available in Velocity, and I'm not sure if it is possible on your side. Here are my details just in case you need for reference: