saif-ellafi / foundryvtt-mythic-gme

Mythic GM Emulator Macros and Roll Tables
Other
27 stars 15 forks source link

undefined in chat with 2.6.1 and foundry 9 #25

Closed bayang closed 1 year ago

bayang commented 1 year ago

Hi, thanks for this module !

I'm testing in foundry v9 build 280.

When installing your module, it is the latest that is installed (2.6.1) and a warning popup appears in foundy saying that this module does not publish compatibility data or something like that (the message only appears a brief moment). When using this version, when checking for scene alteration for example, if a random event appears and several dice rolls happen in a row, only two messages appear : an undefined one and the latest one which gets overwritten with each dice roll.

Screenshot_20220912_214915

Here is the only error in console :

Screenshot_20220912_214939

I tried to uninstall and force a downgrade of your module (using a json module direct link) to version 2.5.12 (before v10 compatibility), this version works flawlessly.

Screenshot_20220912_185721

Is there a way when installing your module, to pin versions that are compatible ? (I don't know foundry well, I'm just beginning). For example is user if on foundry v10, the latest module is downloaded, but if user is on v9 only 2.5.x versions are downloaded ?

Thanks again !

saif-ellafi commented 1 year ago

Hey @bayang - thanks for reporting this, v2.6.1 should not be possible to install in v10 :( I hope I didn't mess up

saif-ellafi commented 1 year ago

It is really strange that you could install v9 and 2.6.1 "compatibility": { "minimum": "10", "verified": "10.284", "maximum": "10" },

bayang commented 1 year ago

Don't worry ! I managed to try to reinstall and be quick enough to get the error popup :

mythic_popup

And here is the warning that is displayed when install is complete :

mythic_compat

So for know, the workaround is to install by providing the direct link to the json module of latest 2.5.x version.

saif-ellafi commented 1 year ago

Thanks, alright. Yes I found the problem. Foundry should have been more explicit about this, and I didn't read the docs carefully. Will fix it, although I can't rollback on behalf of others :(

saif-ellafi commented 1 year ago

I have now solved this. Uninstall and re-install should give you the latest version possible for v9. Thanks for letting me know