sail-sg / envpool

C++-based high-performance parallel environment execution engine (vectorized env) for general RL environments.
https://envpool.readthedocs.io
Apache License 2.0
1.1k stars 100 forks source link

[BUG] Build failes due to Bazel 7.0.0 breaking change #291

Open rhaps0dy opened 10 months ago

rhaps0dy commented 10 months ago

Describe the bug

When building in the default Docker env, the following error comes up

ERROR: /app/envpool/atari/BUILD:20:8: output 'envpool/atari/roms' of //envpool/atari:gen_atari_roms is a directory; dependency checking of directories is unsound
ERROR: /app/envpool/atari/BUILD:20:8: Executing genrule //envpool/atari:gen_atari_roms failed: not all outputs were created or valid

To Reproduce

  1. Run make docker-dev
  2. Inside the container run make bazel-debug

Expected behavior

The code builds

System info

I reproduced this bug:

Reason and Possible fixes

I was able to work around this by setting export USE_BAZEL_VERSION=6.4.0. Then Bazelisk downloads and runs the appropriate Bazel version. I suggest adding that to the documentation.

Bazel 7.0.0 disables version checking for directories and symlinks, because it's unsound. (I gleaned this from this GitHub issue) Envpool has some genrules that output directories.

Checklist