search

sailfishos / sailfish-components-webview

Mozilla Public License 2.0
13 stars 23 forks source link

Add WebEngine documentation #108

Closed llewelld closed 3 years ago

llewelld commented 3 years ago

Applied on top of some of the other documentation commits. I'll rebase it all once they're merged.

llewelld commented 3 years ago

Early review. I need to refresh my memory regarding C++ docs but we should expose both C++ and QML docs.

Thanks for the useful comments. I'll make sure I expand on the C++ docs as well as the QML ones.

llewelld commented 3 years ago

Now rebased so there's only one commit.

llewelld commented 3 years ago

Updated to reflect initialised and pixelRatio being properties.

llewelld commented 3 years ago

I've removed QMozContext::pixelRatio from the documentation to align with the changes in https://git.sailfishos.org/mer-core/qtmozembed/merge_requests/95.

llewelld commented 3 years ago

Fixed some typos.

llewelld commented 3 years ago

Thanks for all the helpful suggestions.

llewelld commented 3 years ago

Rebased and addressed conflicts.

llewelld commented 3 years ago

I've made all of the QMozContext docs part of WebEngine instead. It's in a separate commit, so I can revert it if it's a retrograde step. It certainly makes things clearer and simpler.

llewelld commented 3 years ago

Fixed up with the suggestions (thanks Raine), squashed and rebased.