search

sailfishos / sailfish-components-webview

Mozilla Public License 2.0
13 stars 23 forks source link

Act on private browsing when requesting permissions. JB#55925 OMP#JOLLA-445 #131

Closed llewelld closed 3 years ago

llewelld commented 3 years ago

A privateBrowsing flag is now passed with the "embed:permissions" message when the browser wants to request a permission of the user (a location permission specifically).

This change disables the option to store the permission when private browsing is enabled, to avoid leaking location data.

llewelld commented 3 years ago

Requires https://github.com/sailfishos/embedlite-components/pull/65

For info, with these PRs the behaviour of the Location Permission is now as follows:

In normal browsing mode:

  1. Accepting or Denying the permission temporarily will last until the browser is restarted. The setting will apply to private browsing mode as well.
  2. Accepting or Denying the permission permanently will last until the user clears the permissions via the settings. The setting will apply to private browsing mode as well.

In private browsing mode:

  1. Accepting or Denying the permission temporarily will be applied only once. If the site requests access again the user will be asked again. This has no effect on normal mode because nothing is stored.
  2. There is no option to Accept or Deny permanently.
llewelld commented 3 years ago

Rebased.