search

sailfishos / sailfish-components-webview

Mozilla Public License 2.0
13 stars 23 forks source link

[webview] Align to ViewCreator API changes. JB#56631 OMP#JOLLA-569 #142

Closed rainemak closed 2 years ago

rainemak commented 2 years ago

Browsing context cannot be optional for sub windows.

rainemak commented 2 years ago

This PR supersedes https://github.com/sailfishos/sailfish-components-webview/pull/141

chriadam commented 2 years ago

One comment (which might not be valid anyway), aside from that LGTM.

rainemak commented 2 years ago

One comment (which might not be valid anyway), aside from that LGTM.

Currently API is marked as internal (highlighted it in previous comment). Mismatches between parent-child browsing contexts will assert inside the engine. Only way to bypass on QML side window.open to somewhat work is to break parent-child relationship between parent&child webview => i.e. treat parentId always is zero. This of course have implications like parent web content cannot close created child not can child close itself.

This implies that for QML we need at some point better API.