Race changer: wrong mounts

[GoogleCodeExporter]

What steps will reproduce the problem?
Change race.

What is the expected output? What do you see instead?
with some changes the mount doesn't change correctly, for example changing 
from troll and blood elf to human. You get a wolf instead of a horse.
I didn't test all possible combinations yet.

What revision of the product are you using? In what browser?
25 google chrome

What version are you using? MangosWeb or TrinityWeb?
Trinityweb

Please provide any additional information below.

Original issue reported on code.google.com by roelverheggen3006@gmail.com on 27 Mar 2010 at 10:15

[GoogleCodeExporter]

I tested some more and it only happens when you change to human, it doesn't 
matter from 
what race you change. I will try to find the problem and post the fix.

Original comment by roelverheggen3006@gmail.com on 27 Mar 2010 at 11:24

[GoogleCodeExporter]

ok, I fixed it, it was just a small line of code that was forgotten.
break; should be added after
function addMounts($guid,$race,$CHDB) {
global $CHDB;
switch ($race) {
case 1:
$mount1 = 472;
$mount2 = 23229;

You just need to replace the old file in \components\account\ with this file.

Original comment by roelverheggen3006@gmail.com on 27 Mar 2010 at 11:36

Attachments:

• account.chartools.php

[GoogleCodeExporter]

I guess you will find all my help very useful, I do this for myself but want to 
share 
it with you since you share this project.

I edited \templates\offlike\account\account.chartools.php, it now has the 
online 
check and I added something so you are not able to change faction if you are in 
a 
guild. You will have to leave the guild first. Guild leaders should make 
somebody 
else the leader.
You will have to change $con = mysql_connect("localhost","trinity","trinity"); 
with 
your database username and pass but I am sure you know a better way.

Original comment by roelverheggen3006@gmail.com on 27 Mar 2010 at 3:02

Attachments:

• account.chartools.php

[GoogleCodeExporter]

I will definatly use this :D thanks a bunch. I will edit it to use the global
database connection settings that the website uses so no extra setup required :)

Original comment by wilson.steven10@gmail.com on 27 Mar 2010 at 4:08

[GoogleCodeExporter]

ok great, but I have a little more :D
I added 2 new lines in this file for if you change faction. When you change 
from horde 
to alliance, you will start in stormwind at next login. If you change from 
alliance in 
horde, you will start in Orgrimmar next login.
I just added this so people won't be in enemy territory at the next login.

Original comment by roelverheggen3006@gmail.com on 27 Mar 2010 at 4:33

Attachments:

• account.chartools.php

[GoogleCodeExporter]

I also noticed your changes to my code made popup the guild warning even if you 
only 
change race within a faction.

Original comment by roelverheggen3006@gmail.com on 27 Mar 2010 at 5:06

[GoogleCodeExporter]

For this last I just changed
if((isAlliance($newrace) && !isAlliance($oldrace)) || (!isAlliance($newrace) && 
isAlliance($oldrace)) && $check_guild == 0)

in

if((((isAlliance($newrace) && !isAlliance($oldrace)) || (!isAlliance($newrace) 
&& 
isAlliance($oldrace))) && $check_guild == 0)||((isAlliance($newrace) && 
isAlliance($oldrace)) || (!isAlliance($newrace) && !isAlliance($oldrace))))

maybe a little long but it works.

I also noticed that when changing factions and you are mage, your teleport 
spells 
will remain on the action bar and you can still use them. This is nothing bad 
since 
the spells are not in your book anymore, you will need to learn the teleport 
spells 
for the other cities and you can just remove the icons from the action bar.

Original comment by roelverheggen3006@gmail.com on 27 Mar 2010 at 5:40

[GoogleCodeExporter]

Obviously the faction change needs alot of work :) ... Your work is greatly
appreciated as i am short on time this weekend :) .. thank you. Please, if you 
have
more ideas, share them :)

Original comment by wilson.steven10@gmail.com on 27 Mar 2010 at 5:52

• Changed state: Accepted

[GoogleCodeExporter]

Original comment by wilson.steven10@gmail.com on 29 Mar 2010 at 7:31

• Changed state: Done