search

sakura-ryoko / minihud

A client-side Minecraft mod with configurable "info lines" ("mini-F3") and various overlays, such as light level and structure bounding boxes
GNU Lesser General Public License v3.0
290 stars 19 forks source link

Korean Crowdin lang files update request #74

Open MagPlum opened 4 days ago

MagPlum commented 4 days ago

Hello, I would like to contribute a Korean translation for the MiniHUD mod. Here is my translation json file named 'ko_kr_2.json' just to distinguish. Please let me know if there is anything that needs to be corrected. ko_kr_2.json

I have two more requests and two questions.

  1. In Korean language setting, 'RESET' key is translated as '다시 놓기'. Please change it to '리셋'.
  2. Also in the actionbar notification, 'ON' and 'OFF' are translated as '에' and '끄다'. Please change it back to 'ON' and 'OFF'.
  3. Comments for 'lightLevelMarkerBlockLit' and 'lightLevelMarkerSkyLit' are same. Shouldn't (during day) in 'lightLevelMarkerBlockLit' be deleted?
  4. In the comment to 'infoZombieConversion', it says (Husk) after skeleton. Shouldn't it be changed to (Stray)?

I always get a lot of help from the MiniHUD mod. Thank you very much.

image image image image

sakura-ryoko commented 3 days ago

Yes, if the "RESET" and a few of the other translations of the Menus is wrong, there is also the lang file under malilib here, for example:

"malilib.gui.button.reset": "다시 놓기",

From --> https://github.com/sakura-ryoko/malilib/blob/665d8e09984bfc6647b2dfebfe82f2f3e3d1fb75/src/main/resources/assets/malilib/lang/ko_kr.json

sakura-ryoko commented 3 days ago

These lang files were introduced strictly from AI / Machine translations, so I am not surprised if they aren't very good, overall.

sakura-ryoko commented 3 days ago

With the lightLevelMarkerBlockLit I'm not too sure off hand, but I believe they are correct... I didn't write those two.

MagPlum commented 2 days ago

Yes, if the "RESET" and a few of the other translations of the Menus is wrong, there is also the lang file under malilib here, for example:

I see, maybe I can translate that file someday. Thanks.

With the lightLevelMarkerBlockLit I'm not too sure off hand, but I believe they are correct... I didn't write those two.

Spots marked by 'lightLevelMarkerBlockLit' are always spawn proofed by light source like torches or glowstones. So it doesn't have to specify as (during day). However spots marked by 'lightLevelMarkerSkyLit' are only spawn proofed by sunlight during day time. And I think that is why they wrote (during day) in the first place. But ok. It is only my opinion so I don't insist.

Thank you for reply.

sakura-ryoko commented 1 day ago

Hello, Just an FYI, while I was doing my Crowdin cleanup, I have accidentally omitted your korean file for MiniHUD; and I've since re-added it to the Github repo. Also, due to this, the Korean file under MaLiLib was removed also. So, if you wish to have Korean under MaLiLib's prompts, also; you can help by doing MaLiLib's lang file also.