search

salarkhan / git-pear

swap credentials after each commit
3 stars 0 forks source link

Can't uninstall outside of a git directory #55

Closed supertopher closed 10 years ago

supertopher commented 10 years ago

We are checking for git directory before we are checking for uninstall. it is likely that users may want to uninstall pear without being in a git directory.
1300910359_basketball-stadium-shot

supertopher commented 10 years ago

i'm not sure how to elegantly deal with this problem. i don't like the idea of another 5 lines just to catch uninstall. is it asking too much to be in a git directory to uninstall?

salarkhan commented 10 years ago

I think so.

utility > elegance

how ugly are these additional 5 lines?

supertopher commented 10 years ago

basically just checking for quit before we check for is this a git directory. then checking for any other commands after that. It seems really really not dry

salarkhan commented 10 years ago

Quit or uninstall?

Regardless I think its ok to ask em to be in a git dir -- we're gonna eventually move to homebrew anyway

supertopher commented 10 years ago

uninstall*

salarkhan commented 10 years ago

Yeah, fuggit. So long as homebrew is in the pipeline, I think? I'm ok with asking them to be in a git directory for uninstallation

supertopher commented 10 years ago

fo sho