Open salarkhan opened 10 years ago
Just submitted the PR so we can tag team this sucka.
I'm assuming in the code I gotta do something like the following for the optional API key idea
if [ $SGU_API_KEY ]; then
local json=`curl -H "Authorization: token $SGU_API_KEY" -s https://api.github.com/users/$username`
else
local json=`curl -s https://api.github.com/users/$username`
fi
i haven't done OAuth is a goddamn millenia, so I'm just gonna leave this here for when it isn't 3 in the morn --------> github oath ish
@supertopher 4 API calls. jesus.
thinking we store the full names in the git config?
progress doe!
@supertopher it is done.
need to DRY the json parsing up, but im down to put that aside till after brew install works
@supertopher lemme know if you wanna do homebrew. maybe we can get @Souldjinn on this ish
the error message for failing to get a username says update your email address not update your user name
That's because we need their email address to retrieve their username. And then we make a second call to get their full name using that username
i've tested this locally twice unless i'm fucking up some spelling i am not getting name resolution.
this is my solo
and maybe we could tell the user which email address it is failing on?
This may be an outlier but i'm not pulling a name solo (note some old cruft in the config, though i don't think it is causing errors)
confused...cause that's not happening to me:
how the shit do you resize your images?!
Fixes #58