search

salcode / bootstrap-genesis

WordPress Genesis Child Theme setup to use Bootstrap, Sass, and Grunt
MIT License
183 stars 63 forks source link

use filter to add pipe character in between a post’s Author | Comments #164

Closed colorful-tones closed 4 years ago

colorful-tones commented 8 years ago

Fixes #104

salcode commented 8 years ago

Thanks for the PR @colorful-tones

There does seem to be an edge case for when the comments are disabled (see screenshot)

Logged Out and Disabled Comments

screenshot 2016-09-28 14 00 20

Interestingly, it seems it would still be nice to have the bar when comments are disabled (when the user is logged in).

Logged In and Disabled Comments

screenshot 2016-09-28 14 04 11

What does the Genesis Sample Theme do?

I like how the Genesis Sample Theme handles this.

Logged In and Disabled Comments

screenshot 2016-09-28 14 02 06

Logged Out and Disabled Comments

screenshot 2016-09-28 14 05 16

Logged In and Enabled Comments

screenshot 2016-09-28 14 05 48

Logged Out and Enabled Comments

screenshot 2016-09-28 14 06 21

It may be worth looking at how they set it up in the Genesis Sample Theme.