Set partition when Kafka::consume is called without calling set_partition first
Fixed format string used to write to syslog (%d of int64_t -> PRId64, %d for char *offset -> %s)
Updated the READEME.md
Check argument value passed to Kafka::set_partition -> throws exception in case of an invalid argument
Reduce wait in kafka_destroy to 10ms
Add checks to return value of msg_consume, only adding actual messages to return_value
Add destructor, so as to not postpone rd_kafka_Destroy needlessly
Possible follow-up PR:
add connect and disconnect methods, perhaps allowing users to specify the wait in MS
Add beginning and end offset constants
Deprecate the set_partition method, and replace it with a more PSR-compliant setPartition method (camel-cased methods are preferred 21 to 1 -> http://www.php-fig.org/psr/psr-2/)
Kafka::consumeis called without callingset_partitionfirstint64_t->PRId64, %d forchar *offset->%s)Kafka::set_partition-> throws exception in case of an invalid argumentkafka_destroyto 10msmsg_consume, only adding actual messages toreturn_valuerd_kafka_DestroyneedlesslyPossible follow-up PR:
connectanddisconnectmethods, perhaps allowing users to specify the wait in MSset_partitionmethod, and replace it with a more PSR-compliantsetPartitionmethod (camel-cased methods are preferred 21 to 1 -> http://www.php-fig.org/psr/psr-2/)