search

saleor / apps

A central space for Saleor Apps, integrations, and the App Store 🚀
https://apps.saleor.io
Other
114 stars 316 forks source link

Migrate to `.eslintrc.cjs` Eslint config files #1584

Closed krzysztofzuraw closed 2 months ago

krzysztofzuraw commented 2 months ago

Scope of the PR

As we are using https://github.com/saleor/eslint-plugin-saleor-app in monorepo we need to have tsconfigRootDir: __dirname, inside Eslint config so lint staged will know which tsconfig to use. Unfortunately this setting can't be added to JSON based config - it has to be JS based config - hence the change.

Related issues

Checklist

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saleor-app-avatax 🛑 Canceled (Inspect) 💬 Add feedback Sep 24, 2024 1:35pm
saleor-app-cms ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 24, 2024 1:35pm
saleor-app-data-importer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 24, 2024 1:35pm
saleor-app-klaviyo 🛑 Canceled (Inspect) Sep 24, 2024 1:35pm
saleor-app-products-feed ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 24, 2024 1:35pm
saleor-app-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 24, 2024 1:35pm
saleor-app-smtp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 24, 2024 1:35pm
changeset-bot[bot] commented 2 months ago

⚠️ No Changeset found

Latest commit: 32a4b1d1031d4acda7220d762162834eb2e263e5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR