search

saleor / saleor-dashboard

A GraphQL-powered, single-page dashboard application for Saleor.
BSD 3-Clause "New" or "Revised" License
846 stars 1.11k forks source link

Variants take on SKU name instead of variant name #1963

Closed basedceo closed 1 year ago

basedceo commented 2 years ago

What I'm trying to achieve

… create a product with variants similar to the pre-defined ones (red hoodie similar to existing black hoodie)

Steps to reproduce the problem

  1. create a product with the type Top (clothing)
  2. Create some variants using the create similar variant method (multi variant creation is very buggy btw, but I have a separate bug report open for that)
  3. If you enter the sku for the variant and click save, it will name the variant after the sku, if you don't enter a sku it gets a long alpha-numeric name (possibly a variant ID)
  4. this sku/variant name also shows in the storefront for the product, so its a very big problem as the customer will not understand what variant they are choosing

What I expected to happen

The variant to have a more sensible name given to it automatically, such as the variant attributes value (that's what all the pre-made products seem to do), or have an option to specifically define the name of the variant in the dashboard.

Screenshots

https://user-images.githubusercontent.com/99623735/160668043-a3f5eea7-9db0-4923-b79a-55162530f79c.mp4

Http request and response from inspector

// insert request and response here

Console output

// insert console output here

System information

Saleor version:

Operating system:

Browser:

RyanTamulevicz commented 2 years ago

I see you said that this issue is happening at 3.1.4 and 3.1.7, but I also had it at 3.1.0.

basedceo commented 2 years ago

@RyanTamulevicz yeah, if you downgrade to 3.0 it doesn't seem to have this problem, I'm guessing the issue was introduced in a more recent commit.

RyanTamulevicz commented 2 years ago

I can also confirm this isn't an issue directly with the dashboard directly it seems... Using Dashboard 3.0.0 and updated API Core, it still changes the variant names to the SKU

timuric commented 2 years ago

Related #2000

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.