search

saleor / saleor-storefront

A GraphQL-powered, NextJs-based, PWA storefront for Saleor. IMPORTANT: This project is [DEPRECATED] in favor of saleor/react-storefront soon to become our default demo and storefront starter pack.
https://demo.saleor.io/
BSD 3-Clause "New" or "Revised" License
770 stars 672 forks source link

Fix 404 page issue on payment complete #1098

Closed orzechdev closed 3 years ago

orzechdev commented 3 years ago

I want to merge this change because... it fixes improperly displayed 404 page when checkout payment is completed and now shows the order details page.

Fixes https://github.com/mirumee/saleor/issues/8081

Screenshots

Before:

Zrzut ekranu 2021-09-14 o 18 13 58

After:

Zrzut ekranu 2021-09-14 o 18 13 47

Pull Request Checklist

  1. [x] All visible strings are translated with proper context.
  2. [x] All data-formatting is locale-aware (dates, numbers, and so on).
  3. [x] The changes are tested.
  4. [x] The code is documented (docstrings, project documentation).
  5. [x] Changes are mentioned in the changelog.

Test Environment Config

API_URI=https://qa.staging.saleor.cloud/graphql/

patrys commented 3 years ago

Task linked: SALEOR-4425 Stripe plugin issue

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

storefront-master-staging – ./

🔍 Inspect: https://vercel.com/saleorcommerce/storefront-master-staging/ESLSa5K4soVLxmdhPQhdHdjBvzHX
✅ Preview: https://storefront-master-staging-git-saleor-4425-f0dedd-saleorcommerce.vercel.app

storefront-qa – ./

🔍 Inspect: https://vercel.com/saleorcommerce/storefront-qa/BiytLaZuiywvam7tUaiUsGLomco1
✅ Preview: https://storefront-qa-git-saleor-4425-fix-404-on-d3b892-saleorcommerce.vercel.app

storefront-stable-staging – ./

🔍 Inspect: https://vercel.com/saleorcommerce/storefront-stable-staging/CraHKZnptTyWb3HWqKQp8RqsBMkh
✅ Preview: https://storefront-stable-staging-git-saleor-4425-850085-saleorcommerce.vercel.app

internal-demo-storefront – ./

🔍 Inspect: https://vercel.com/saleorcommerce/internal-demo-storefront/FyfXV1zeZepVixQN4T655FfgzD6W
✅ Preview: https://internal-demo-storefront-git-saleor-4425-d816ed-saleorcommerce.vercel.app

storefront-demo – ./

🔍 Inspect: https://vercel.com/saleorcommerce/storefront-demo/CFL6jREJ6rtvk7UtMFCrRHu29tvR
✅ Preview: https://storefront-demo-git-saleor-4425-fix-404-o-4b687a-saleorcommerce.vercel.app

patrys commented 3 years ago

Task linked: SALEOR-3836 Storefront shows 404 if user uses another payment than Dummy