search

saleor / saleor-storefront

A GraphQL-powered, NextJs-based, PWA storefront for Saleor. IMPORTANT: This project is [DEPRECATED] in favor of saleor/react-storefront soon to become our default demo and storefront starter pack.
https://demo.saleor.io/
BSD 3-Clause "New" or "Revised" License
770 stars 672 forks source link

Variable to change the "Saleor" name #945

Closed macabeus closed 3 years ago

macabeus commented 4 years ago

What I'm trying to achieve

Easer configuration and futures updates.

Describe a proposed solution

Like explained on readme, we should update to files to changes the app name Saleor. But changing the codebase isn't very well, because could be harder to update the storefront version and isn't beginner friendly IMHO.

We could add the new configuration APP_NAME on src/core/config.ts.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Luka-Abey commented 3 years ago

I agree, would be good to just have it as a variable in the config !

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.