search

saleor / saleor-storefront

A GraphQL-powered, NextJs-based, PWA storefront for Saleor. IMPORTANT: This project is [DEPRECATED] in favor of saleor/react-storefront soon to become our default demo and storefront starter pack.
https://demo.saleor.io/
BSD 3-Clause "New" or "Revised" License
770 stars 672 forks source link

Update types and components #990

Closed bmigirl closed 3 years ago

bmigirl commented 3 years ago

I want to merge this change because it adds handling of new description and content fields instead of old json fields

ticket

Screenshots

Pull Request Checklist

  1. [ ] All visible strings are translated with proper context.
  2. [ ] All data-formatting is locale-aware (dates, numbers, and so on).
  3. [ ] The changes are tested.
  4. [ ] The code is documented (docstrings, project documentation).
  5. [ ] Changes are mentioned in the changelog.

Test Environment Config

API_URI=https://master.staging.saleor.cloud/graphql/

patrys commented 3 years ago

Task linked: SALEOR-2170 Drop deprecated JSON fields in Storefront/SDK

krzysztofwolski commented 3 years ago

(but jest tests are falling!)

piotrgrundas commented 3 years ago

U can bump editorjs and enable readOnly mode. They resolved the relevant issue 👌

bmigirl commented 3 years ago

Along with @krzysztofwolski we weren't able to figure out why enzyme doesn't render the editor content correctly (instead it renders jsx tags and no jsx / text content) so updated the test to simple snapshot since that's all it did anyway.